Make the IME menu panel more system-like.

Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the menu will always be shown on the right, and un-removable between other panel windows.

BUG=570761
TEST=Verified on local build.

Committed: https://crrev.com/3c9d1f693a13c10ec75e3845ca070c9d628037e9
Cr-Commit-Position: refs/heads/master@{#393752}

[Azure Wei, 2016-05-12 11:36:10]

Description was changed from

==========
Make the IME menu panel more system-like.

BUG=570761
TEST=Verified on local build.
==========

to

==========
Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the
menu will always be shown on the right, and un-removable between other panel
windows.
 
BUG=570761
TEST=Verified on local build.
==========

[Azure Wei, 2016-05-12 11:36:10]

azurewei@chromium.org changed reviewers:
+ shuchen@chromium.org, sky@chromium.org

[Azure Wei, 2016-05-12 11:37:30]

Hi Shu and sky@, can you please review this? Thanks!

[sky, 2016-05-12 16:55:51]

sky@chromium.org changed reviewers:
+ msw@chromium.org

[sky, 2016-05-12 16:55:52]

+msw
LGTM

https://codereview.chromium.org/1978443002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/launcher_item_controller.cc (right):

https://codereview.chromium.org/1978443002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/launcher_item_controller.cc:24: if
(extension_misc::IsImeMenuExtensionId(app_id_)) {
nit: no {}

[msw, 2016-05-12 19:23:47]

The mash shelf doesn't support panels yet; we'll need to address that and this
new IME menu.

[Azure Wei, 2016-05-13 07:19:07]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 07:19:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978443002/20001

[Azure Wei, 2016-05-13 07:56:36]

The CQ bit was unchecked by azurewei@chromium.org

[Azure Wei, 2016-05-13 08:09:37]

On 2016/05/12 16:55:52, sky wrote:
> +msw
> LGTM
> 
>
https://codereview.chromium.org/1978443002/diff/1/chrome/browser/ui/ash/launc...
> File chrome/browser/ui/ash/launcher/launcher_item_controller.cc (right):
> 
>
https://codereview.chromium.org/1978443002/diff/1/chrome/browser/ui/ash/launc...
> chrome/browser/ui/ash/launcher/launcher_item_controller.cc:24: if
> (extension_misc::IsImeMenuExtensionId(app_id_)) {
> nit: no {}

Done. Thanks.

[Azure Wei, 2016-05-13 08:10:38]

On 2016/05/12 19:23:47, msw wrote:
> The mash shelf doesn't support panels yet; we'll need to address that and this
> new IME menu.

Is there anything I should do in this cl?

[msw, 2016-05-13 16:05:53]

On 2016/05/13 08:10:38, Azure Wei wrote:
> On 2016/05/12 19:23:47, msw wrote:
> > The mash shelf doesn't support panels yet; we'll need to address that and
this
> > new IME menu.
> 
> Is there anything I should do in this cl?

Nope! Just a side note, but feel free to reach out if you're interested.

[Azure Wei, 2016-05-14 05:55:15]

On 2016/05/13 16:05:53, msw wrote:
> On 2016/05/13 08:10:38, Azure Wei wrote:
> > On 2016/05/12 19:23:47, msw wrote:
> > > The mash shelf doesn't support panels yet; we'll need to address that and
> this
> > > new IME menu.
> > 
> > Is there anything I should do in this cl?
> 
> Nope! Just a side note, but feel free to reach out if you're interested.

OK. Thanks.

[Azure Wei, 2016-05-14 05:55:23]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-05-14 05:55:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1978443002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-14 05:55:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978443002/20001

[Azure Wei, 2016-05-14 10:36:27]

The CQ bit was checked by azurewei@chromium.org

[commit-bot: I haz the power, 2016-05-14 10:36:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978443002/20001

[commit-bot: I haz the power, 2016-05-14 20:37:36]

Description was changed from

==========
Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the
menu will always be shown on the right, and un-removable between other panel
windows.
 
BUG=570761
TEST=Verified on local build.
==========

to

==========
Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the
menu will always be shown on the right, and un-removable between other panel
windows.
 
BUG=570761
TEST=Verified on local build.
==========

[commit-bot: I haz the power, 2016-05-14 20:37:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-14 20:40:04]

Description was changed from

==========
Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the
menu will always be shown on the right, and un-removable between other panel
windows.
 
BUG=570761
TEST=Verified on local build.
==========

to

==========
Make the IME menu panel more system-like.

Add a new ShelfItemType::TYPE_IME_MENU for the IME menu in the shelf. So the
menu will always be shown on the right, and un-removable between other panel
windows.

BUG=570761
TEST=Verified on local build.

Committed: https://crrev.com/3c9d1f693a13c10ec75e3845ca070c9d628037e9
Cr-Commit-Position: refs/heads/master@{#393752}
==========

[commit-bot: I haz the power, 2016-05-14 20:40:05]

Patchset 2 (id:??) landed as
https://crrev.com/3c9d1f693a13c10ec75e3845ca070c9d628037e9
Cr-Commit-Position: refs/heads/master@{#393752}