Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1978383002: Add learning expectations to predictor browsertests (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add learning expectations to predictor browsertests This patch adds some EXPECT calls to investigate DrMemory test failures. The hypothesis is that the tests are so slow to run that by the time a URLRequest starts, the navigation that triggered happened over 10s ago. This would cause the predictor to not learn the request relationship. BUG=612240 Committed: https://crrev.com/fee59f9f4cf1ebbc6f208fc6b823fa6cf1385518 Cr-Commit-Position: refs/heads/master@{#393929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/net/predictor_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Harrison
ptal, thanks.
4 years, 7 months ago (2016-05-16 20:06:05 UTC) #2
mmenke
On 2016/05/16 20:06:05, csharrison wrote: > ptal, thanks. LGTM
4 years, 7 months ago (2016-05-16 20:06:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978383002/1
4 years, 7 months ago (2016-05-16 20:10:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 21:17:58 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:19:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fee59f9f4cf1ebbc6f208fc6b823fa6cf1385518
Cr-Commit-Position: refs/heads/master@{#393929}

Powered by Google App Engine
This is Rietveld 408576698