Correctly ignore AXTree event creation change state for reparented nodes

ui/accessibility/ax_tree_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/accessibility/ax_tree.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 44 matching lines @@
 
     for (size_t i = 0; i < changes.size(); ++i) {
       int id = changes[i].node->id();
       switch (changes[i].type) {
         case NODE_CREATED:
           node_creation_finished_ids_.push_back(id);
           break;
         case SUBTREE_CREATED:
           subtree_creation_finished_ids_.push_back(id);
           break;
+        case NODE_REPARENTED:
+          node_reparented_finished_ids_.push_back(id);
+          break;
+        case SUBTREE_REPARENTED:
+          subtree_reparented_finished_ids_.push_back(id);
+          break;
         case NODE_CHANGED:
           change_finished_ids_.push_back(id);
           break;
       }
     }
   }
 
   bool tree_data_changed() const { return tree_data_changed_; }
   bool root_changed() const { return root_changed_; }
   const std::vector<int32_t>& deleted_ids() { return deleted_ids_; }
   const std::vector<int32_t>& subtree_deleted_ids() {
     return subtree_deleted_ids_;
   }
   const std::vector<int32_t>& created_ids() { return created_ids_; }
   const std::vector<int32_t>& node_creation_finished_ids() {
     return node_creation_finished_ids_;
   }
   const std::vector<int32_t>& subtree_creation_finished_ids() {
     return subtree_creation_finished_ids_;
   }
+  const std::vector<int32_t>& node_reparented_finished_ids() {
+    return node_reparented_finished_ids_;
+  }
+  const std::vector<int32_t>& subtree_reparented_finished_ids() {
+    return subtree_reparented_finished_ids_;
+  }
   const std::vector<int32_t>& change_finished_ids() {
     return change_finished_ids_;
   }
 
  private:
   bool tree_data_changed_;
   bool root_changed_;
   std::vector<int32_t> deleted_ids_;
   std::vector<int32_t> subtree_deleted_ids_;
   std::vector<int32_t> created_ids_;
   std::vector<int32_t> changed_ids_;
   std::vector<int32_t> node_creation_finished_ids_;
   std::vector<int32_t> subtree_creation_finished_ids_;
+  std::vector<int32_t> node_reparented_finished_ids_;
+  std::vector<int32_t> subtree_reparented_finished_ids_;
   std::vector<int32_t> change_finished_ids_;
 };
 
 }  // namespace
 
 TEST(AXTreeTest, SerializeSimpleAXTree) {
   AXNodeData root;
   root.id = 1;
   root.role = AX_ROLE_DIALOG;
   root.state = 1 << AX_STATE_FOCUSABLE;
@@ skipping 269 matching lines @@
   AXTreeUpdate tree_data_update;
   tree_data_update.has_tree_data = true;
   tree_data_update.tree_data.title = "New Title";
   EXPECT_TRUE(tree.Unserialize(tree_data_update));
   EXPECT_TRUE(fake_delegate.tree_data_changed());
   EXPECT_EQ("New Title", tree.data().title);
 
   tree.SetDelegate(NULL);
 }
 
+TEST(AXTreeTest, ReparentingDoesNotTriggerNodeCreated) {
+  AXTreeUpdate initial_state;
+  initial_state.root_id = 1;
+  initial_state.nodes.resize(3);
+  initial_state.nodes[0].id = 1;
+  initial_state.nodes[0].child_ids.push_back(2);
+  initial_state.nodes[1].id = 2;
+  initial_state.nodes[1].child_ids.push_back(3);
+  initial_state.nodes[2].id = 3;
+
+  FakeAXTreeDelegate fake_delegate;
+  AXTree tree(initial_state);
+  tree.SetDelegate(&fake_delegate);
+
+  AXTreeUpdate update;
+  update.nodes.resize(2);
+  update.node_id_to_clear = 2;
+  update.root_id = 1;
+  update.nodes[0].id = 1;
+  update.nodes[0].child_ids.push_back(3);
+  update.nodes[1].id = 3;
+  EXPECT_TRUE(tree.Unserialize(update)) << tree.error();
+  std::vector<int> created = fake_delegate.node_creation_finished_ids();
+  std::vector<int> subtree_reparented =
+      fake_delegate.subtree_reparented_finished_ids();
+  std::vector<int> node_reparented =
+      fake_delegate.node_reparented_finished_ids();
+  ASSERT_EQ(std::find(created.begin(), created.end(), 3), created.end());
+  ASSERT_NE(std::find(subtree_reparented.begin(), subtree_reparented.end(), 3),
+            subtree_reparented.end());
+  ASSERT_EQ(std::find(node_reparented.begin(), node_reparented.end(), 3),
+            node_reparented.end());
+}
+
 }  // namespace ui