Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1978363002:
Image filters: fix filtering of transparent black in CFIF. (Closed)
|
Created:
4 years, 7 months ago by Stephen White Modified:
4 years, 7 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionImage filters: fix filtering of transparent black in CFIF.
SkColorFilterImageFilter has a codepath to filter transparent black
regions outside of the input image. However, it was treating the
exterior as opaque black, rather than trasparent black.
Note: the results of imagefiltercropexpand GM will change, as it
was tweaked a bit to show this bug.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978363002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Committed: https://skia.googlesource.com/skia/+/3949971e8d29345ee89461aec1ef25734ffc03f5
Patch Set 1 #Patch Set 2 : Add GM #
Total comments: 1
Patch Set 3 : Add comment per review #Patch Set 4 : Fix upstream for rietveld #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: ========== to ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
senorblanco@chromium.org changed reviewers: + robertphillips@chromium.org
Rob: PTAL. Thanks!
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978363002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Friendly ping. :)
robertphillips@google.com changed reviewers: + robertphillips@google.com
lgtm https://codereview.chromium.org/1978363002/diff/20001/gm/imagefilterscropexpa... File gm/imagefilterscropexpand.cpp (right): https://codereview.chromium.org/1978363002/diff/20001/gm/imagefilterscropexpa... gm/imagefilterscropexpand.cpp:52: sk_sp<SkImageFilter> noopCropped(SkOffsetImageFilter::Make(0, 0, nullptr, &cropRect)); // This color matrix saturates the green component but only partly increases the opacity. // For the opaque checkerboard texture the opacity boost doesn't matter but it does impact the area outside the checkerboard ?
The CQ bit was checked by senorblanco@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1978363002/#ps40001 (title: "Add comment per review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978363002/40001
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by senorblanco@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1978363002/#ps60001 (title: "Fix upstream for rietveld")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978363002/60001
Message was sent while issue was closed.
Description was changed from ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true ========== to ========== Image filters: fix filtering of transparent black in CFIF. SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/3949971e8d29345ee89461aec1ef25734ffc03f5 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/3949971e8d29345ee89461aec1ef25734ffc03f5
Message was sent while issue was closed.
Hmm. Looks like the CQ added NOTRY=true and friends in the previous run with the bad upstream. Will watch the bots. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
