Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1978353003: mac: Fix an attachment broker race condition. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp48_windows_ab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix an attachment broker race condition. If a source or destination communication channel has not been established, the attachment broker will wait for the connection, rather than immediately failing to broker the attachment. BUG=609262 Committed: https://crrev.com/7d2ba5053f23428cb3aad549b2399a4699da339a Cr-Commit-Position: refs/heads/master@{#393915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M ipc/attachment_broker_privileged_mac.h View 3 chunks +9 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 10 chunks +35 lines, -18 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
erikchen
tsepez: Please review.
4 years, 7 months ago (2016-05-16 19:27:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978353003/1
4 years, 7 months ago (2016-05-16 19:28:07 UTC) #4
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-16 19:40:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 20:22:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978353003/1
4 years, 7 months ago (2016-05-16 20:23:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 21:07:26 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:08:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d2ba5053f23428cb3aad549b2399a4699da339a
Cr-Commit-Position: refs/heads/master@{#393915}

Powered by Google App Engine
This is Rietveld 408576698