Support cancelling toast

ash/system/toast/toast_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TOAST_TOAST_MANAGER_H_
 #define ASH_SYSTEM_TOAST_TOAST_MANAGER_H_
 
+#include <list>
 #include <memory>
-#include <queue>
 #include <string>
 
 #include "ash/ash_export.h"
 #include "ash/shell_observer.h"
+#include "ash/system/toast/toast_data.h"
 #include "ash/system/toast/toast_overlay.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 
 namespace ash {
 
 // Class managing toast requests.
 class ASH_EXPORT ToastManager : public ToastOverlay::Delegate {
  public:
   ToastManager();
   ~ToastManager() override;
 
   // Show a toast. If there are queued toasts, succeeding toasts are queued as
   // well, and are shown one by one.
-  void Show(const std::string& text, uint64_t duration_ms);
+  void Show(const ToastData& data);
+
+  void Cancel(const std::string& id);
 
   // ToastOverlay::Delegate overrides:
   void OnClosed() override;
 
  private:
   friend class ToastManagerTest;
+  using QueueElement = std::pair<std::string, ToastData>;

[oshima, 2016/05/16 22:37:25]

toast data has id. Any particular reason to have an element type with id?

[yoshiki, 2016/05/17 06:25:21]

Done.

+  using Queue = std::list<QueueElement>;
 
   void ShowLatest();
-  void OnDurationPassed(int toast_id);
+  void OnDurationPassed(int toast_number);
 
-  int toast_id_for_testing() const { return toast_id_; }
   ToastOverlay* GetCurrentOverlayForTesting() { return overlay_.get(); }
-  void ResetToastIdForTesting() { toast_id_ = 0; }
+  int serial_for_testing() const { return serial_; }
+  void ResetSerialForTesting() { serial_ = 0; }
 
-  int toast_id_ = 0;
-  std::queue<std::pair<std::string, uint64_t>> queue_;
+  std::string toast_id_;

[dcheng, 2016/05/17 02:57:25]

Add a comment what this is: ID of the currently displayed toast, or something.

[yoshiki, 2016/05/17 06:25:21]

Done.

+  int serial_ = 0;
+  Queue queue_;
   std::unique_ptr<ToastOverlay> overlay_;
 
   base::WeakPtrFactory<ToastManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ToastManager);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TOAST_TOAST_MANAGER_H_