Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978303002: NTP article titles and snippets always use 2 lines. (Closed)

Created:
4 years, 7 months ago by Michael van Ouwerkerk
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, bettes_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP article titles and snippets always use 2 lines. Screenshots: http://imgur.com/a/2qTXw BUG=611767 Committed: https://crrev.com/405eb1948f25b0ddebccc05bcd7d98323e2a02ab Cr-Commit-Position: refs/heads/master@{#394090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/res/layout/new_tab_page_snippets_card.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 7 months ago (2016-05-16 17:08:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978303002/1
4 years, 7 months ago (2016-05-16 17:09:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 17:45:09 UTC) #7
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-17 08:11:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978303002/1
4 years, 7 months ago (2016-05-17 09:21:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 09:24:44 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 09:27:10 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/405eb1948f25b0ddebccc05bcd7d98323e2a02ab
Cr-Commit-Position: refs/heads/master@{#394090}

Powered by Google App Engine
This is Rietveld 408576698