Issue 19783003: Rewrite ExtensionApiTest.SandboxedPages to catch exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19783003: Rewrite ExtensionApiTest.SandboxedPages to catch exceptions. (Closed)

Created:
7 years, 5 months ago by Mike West

Modified:
7 years, 5 months ago

Reviewers:
haraken

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Rewrite ExtensionApiTest.SandboxedPages to catch exceptions. https://codereview.chromium.org/19932002/ adjusts cross-origin access violations to throw exceptions rather than dumping messages to the console. This patch fixes the single Chromium test that relied on the old behavior. R=haraken@chromium.org BUG=17325 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213146

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/test/data/extensions/api_test/sandboxed_pages/main.js	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	chrome/test/data/extensions/api_test/sandboxed_pages/sandboxed.html	View		1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/19783003/1

7 years, 5 months ago (2013-07-23 13:17:02 UTC) #2

Message was sent while issue was closed.

Change committed as 213146