Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 197823010: [DevTools] Add minimum size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@splitdip2
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/HeapSnapshotView.js b/Source/devtools/front_end/HeapSnapshotView.js
index e1125faf798e4d3f6d3479b48db0fcee25986648..56399b931b323475d82e35a4bd317f3f39bf2400 100644
--- a/Source/devtools/front_end/HeapSnapshotView.js
+++ b/Source/devtools/front_end/HeapSnapshotView.js
@@ -50,10 +50,9 @@ WebInspector.HeapSnapshotView = function(profile)
this.viewsContainer = new WebInspector.SplitView(false, true, "heapSnapshotSplitViewState", 200, 200);
this.viewsContainer.show(this.element);
- this.viewsContainer.setMainElementConstraints(50, 50);
- this.viewsContainer.setSidebarElementConstraints(70, 70);
this.containmentView = new WebInspector.VBox();
+ this.containmentView.setMinimumSize(new Size(50, 25));
this.containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid();
this.containmentDataGrid.element.addEventListener("mousedown", this._mouseDownInContentsGrid.bind(this), true);
this.containmentDataGrid.show(this.containmentView.element);
@@ -62,6 +61,7 @@ WebInspector.HeapSnapshotView = function(profile)
this.statisticsView = new WebInspector.HeapSnapshotStatisticsView();
this.constructorsView = new WebInspector.VBox();
+ this.constructorsView.setMinimumSize(new Size(50, 25));
this.constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid();
this.constructorsDataGrid.element.addEventListener("mousedown", this._mouseDownInContentsGrid.bind(this), true);
@@ -74,12 +74,14 @@ WebInspector.HeapSnapshotView = function(profile)
this.currentView.show(this.viewsContainer.mainElement());
this.diffView = new WebInspector.VBox();
+ this.diffView.setMinimumSize(new Size(50, 25));
this.diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid();
this.diffDataGrid.show(this.diffView.element);
this.diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
this.dominatorView = new WebInspector.VBox();
+ this.dominatorView.setMinimumSize(new Size(50, 25));
this.dominatorDataGrid = new WebInspector.HeapSnapshotDominatorsDataGrid();
this.dominatorDataGrid.element.addEventListener("mousedown", this._mouseDownInContentsGrid.bind(this), true);
this.dominatorDataGrid.show(this.dominatorView.element);
@@ -87,6 +89,7 @@ WebInspector.HeapSnapshotView = function(profile)
if (WebInspector.experimentsSettings.allocationProfiler.isEnabled() && profile.profileType() === WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType) {
this.allocationView = new WebInspector.VBox();
+ this.allocationView.setMinimumSize(new Size(50, 25));
this.allocationDataGrid = new WebInspector.AllocationDataGrid();
this.allocationDataGrid.element.addEventListener("mousedown", this._mouseDownInContentsGrid.bind(this), true);
this.allocationDataGrid.show(this.allocationView.element);
@@ -101,6 +104,7 @@ WebInspector.HeapSnapshotView = function(profile)
this.viewsContainer.installResizer(this.retainmentViewHeader);
this.retainmentView = new WebInspector.VBox();
+ this.retainmentView.setMinimumSize(new Size(50, 21));
this.retainmentView.element.classList.add("retaining-paths-view");
this.retainmentView.element.appendChild(this.retainmentViewHeader);
this.retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid();
@@ -1815,6 +1819,7 @@ WebInspector.HeapTrackingOverviewGrid.OverviewCalculator.prototype = {
WebInspector.HeapSnapshotStatisticsView = function()
{
WebInspector.VBox.call(this);
+ this.setMinimumSize(new Size(50, 25));
this._pieChart = new WebInspector.PieChart();
this._pieChart.setSize(150);
this.element.appendChild(this._pieChart.element);

Powered by Google App Engine
This is Rietveld 408576698