[DevTools] Add minimum size to WebInspector.View.

Source/devtools/front_end/View.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 258 matching lines @@
             if (insertBefore)
                 WebInspector.View._originalInsertBefore.call(parentElement, this.element, insertBefore);
             else
                 WebInspector.View._originalAppendChild.call(parentElement, this.element);
         }
 
         if (this._parentIsShowing()) {
             this._processWasShown();
             this._cacheSize();
         }
+
+        if (this._parentView)
+            this._parentView.invalidateMinimumSize();
     },
 
     /**
      * @param {boolean=} overrideHideOnDetach
      */
     detach: function(overrideHideOnDetach)
     {
         var parentElement = this.element.parentElement;
         if (!parentElement)
             return;
 
         if (this._parentIsShowing()) {
             this._processDiscardCachedSize();
             this._processWillHide();
         }
 
         if (this._hideOnDetach && !overrideHideOnDetach) {
             this.element.classList.remove("visible");
             this._visible = false;
             if (this._parentIsShowing())
                 this._processWasHidden();
+            if (this._parentView)
+                this._parentView.invalidateMinimumSize();
             return;
         }
 
         // Force legal removal
         WebInspector.View._decrementViewCounter(parentElement, this.element);
         WebInspector.View._originalRemoveChild.call(parentElement, this.element);
 
         this._visible = false;
         if (this._parentIsShowing())
             this._processWasHidden();
 
         // Update view hierarchy
         if (this._parentView) {
             var childIndex = this._parentView._children.indexOf(this);
             WebInspector.View._assert(childIndex >= 0, "Attempt to remove non-child view");
             this._parentView._children.splice(childIndex, 1);
+            var parent = this._parentView;
             this._parentView = null;
+            parent.invalidateMinimumSize();
         } else
             WebInspector.View._assert(this._isRoot, "Removing non-root view from DOM");
     },
 
     detachChildViews: function()
     {
         var children = this._children.slice();
         for (var i = 0; i < children.length; ++i)
             children[i].detach();
     },
@@ skipping 166 matching lines @@
         this._loadCSSIfNeeded();
         WebInspector.View._originalAppendChild.call(document.body, this.element);
         this.element.positionAt(0, 0);
         var result = new Size(this.element.offsetWidth, this.element.offsetHeight);
         this.element.positionAt(undefined, undefined);
         WebInspector.View._originalRemoveChild.call(document.body, this.element);
         this._disableCSSIfNeeded();
         return result;
     },
 
+    /**
+     * @return {!Size}
+     */
+    calculateMinimumSize: function()
+    {
+        return new Size(0, 0);
+    },
+
+    /**
+     * @return {!Size}
+     */
+    minimumSize: function()
+    {
+        if (typeof this._minimumSize !== "undefined")
+            return this._minimumSize;
+        if (typeof this._cachedMinimumSize === "undefined")
+            this._cachedMinimumSize = this.calculateMinimumSize();
+        return this._cachedMinimumSize;
+    },
+
+    /**
+     * @param {!Size} size
+     */
+    setMinimumSize: function(size)
+    {
+        this._minimumSize = size;
+        this.invalidateMinimumSize();
+    },
+
+    invalidateMinimumSize: function()
+    {
+        if (!this._isShowing) {

[pfeldman, 2014/03/14 06:23:10]

Are you sure it needs caching? Not caching would make things so much simpler.
Also, invalidation should happen on its own upon changes in the view hierarchy,
no?

+            delete this._cachedMinimumSize;
+            if (this._parentView && !this._parentView._isShowing)
+                this._parentView.invalidateMinimumSize();
+            return;
+        }
+
+        var cached = this._cachedMinimumSize;
+        delete this._cachedMinimumSize;
+        var actual = this.minimumSize();
+        if (actual && cached && actual.isEqual(cached)) {
+            this.doResize();
+            return;
+        }
+
+        if (this._parentView)
+            this._parentView.invalidateMinimumSize();
+        else
+            this.doResize();
+    },
+
     __proto__: WebInspector.Object.prototype
 }
 
 WebInspector.View._originalAppendChild = Element.prototype.appendChild;
 WebInspector.View._originalInsertBefore = Element.prototype.insertBefore;
 WebInspector.View._originalRemoveChild = Element.prototype.removeChild;
 WebInspector.View._originalRemoveChildren = Element.prototype.removeChildren;
 
 WebInspector.View._incrementViewCounter = function(parentElement, childElement)
 {
@@ skipping 31 matching lines @@
  * @constructor
  * @extends {WebInspector.View}
  */
 WebInspector.VBox = function()
 {
     WebInspector.View.call(this);
     this.element.classList.add("vbox");
 };
 
 WebInspector.VBox.prototype = {
+    /**
+     * @return {!Size}
+     */
+    calculateMinimumSize: function()
+    {
+        var width = 0;
+        var height = 0;
+
+        /**
+         * @param {!WebInspector.View} child
+         */
+        function updateForChild(child)
+        {
+            var size = child.minimumSize();
+            width = Math.max(width, size.width);
+            height += size.height;
+        }
+
+        var childViews = this._children.slice();
+        for (var i = 0; i < childViews.length; ++i) {
+            if (childViews[i]._parentView === this && childViews[i]._visible)

[pfeldman, 2014/03/14 06:23:10]

there is a _callOnVisibleChildren that you could use.

[dgozman, 2014/03/14 15:55:15]

Done.

+                updateForChild(childViews[i]);
+        }
+
+        return new Size(width, height);
+    },
+
     __proto__: WebInspector.View.prototype
 };
 
 /**
  * @constructor
  * @extends {WebInspector.View}
  */
 WebInspector.HBox = function()
 {
     WebInspector.View.call(this);
     this.element.classList.add("hbox");
 };
 
 WebInspector.HBox.prototype = {
+    /**
+     * @return {!Size}
+     */
+    calculateMinimumSize: function()
+    {
+        var width = 0;
+        var height = 0;
+
+        /**
+         * @param {!WebInspector.View} child
+         */
+        function updateForChild(child)
+        {
+            var size = child.minimumSize();
+            width += size.width;
+            height = Math.max(height, size.height);
+        }
+
+        var childViews = this._children.slice();
+        for (var i = 0; i < childViews.length; ++i) {
+            if (childViews[i]._parentView === this && childViews[i]._visible)
+                updateForChild(childViews[i]);
+        }
+
+        return new Size(width, height);
+    },
+
     __proto__: WebInspector.View.prototype
 };
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @param {function()} resizeCallback
  */
 WebInspector.VBoxWithResizeCallback = function(resizeCallback)
 {
@@ skipping 27 matching lines @@
 {
     WebInspector.View._assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
     return WebInspector.View._originalRemoveChild.call(this, child);
 }
 
 Element.prototype.removeChildren = function()
 {
     WebInspector.View._assert(!this.__viewCounter, "Attempt to remove element containing view via regular DOM operation");
     WebInspector.View._originalRemoveChildren.call(this);
 }