Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 1978223002: Destory base class when win platform accessibily node is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/platform/ax_platform_node_win.cc
diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc
index c8f7d5445c3f0cfbf66bed5b8c76c1c193566014..6cf37f457b37a02639a74518787f5001a1852464 100644
--- a/ui/accessibility/platform/ax_platform_node_win.cc
+++ b/ui/accessibility/platform/ax_platform_node_win.cc
@@ -146,6 +146,10 @@ AXPlatformNodeWin::~AXPlatformNodeWin() {
//
void AXPlatformNodeWin::Destroy() {
+ AXPlatformNode::Destroy();
+ // Do not call base class AXPlatformNodeBase::Destroy method because it
+ // would delete this object. Call base's base class AXPlatformNode::Destroy
+ // instead to remove the unique ID from the map like base class does.
delegate_ = nullptr;
RemoveAlertTarget();
Release();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698