components/translate/core/browser/translate_prefs.h - Issue 1978203002: Translate: Remove the legacy pref 'translate_language_blacklist'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_prefs.h

Issue 1978203002: Translate: Remove the legacy pref 'translate_language_blacklist' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc ('k') | components/translate/core/browser/translate_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_prefs.h

diff --git a/components/translate/core/browser/translate_prefs.h b/components/translate/core/browser/translate_prefs.h

index 65c3befcf10553364b948acd4048a986368b779a..8c803a5e743deb63c5dcb75bb4cb395ea10a24f8 100644

--- a/components/translate/core/browser/translate_prefs.h

+++ b/components/translate/core/browser/translate_prefs.h

@@ -99,10 +99,6 @@ class TranslatePrefs {

void BlockLanguage(const std::string& original_language);

void UnblockLanguage(const std::string& original_language);

- // Removes a language from the old blacklist. Only used internally for

- // diagnostics. Don't use this if there is no special reason.

- void RemoveLanguageFromLegacyBlacklist(const std::string& original_language);

bool IsSiteBlacklisted(const std::string& site) const;

void BlacklistSite(const std::string& site);

void RemoveSiteFromBlacklist(const std::string& site);

@@ -167,9 +163,6 @@ class TranslatePrefs {

private:

friend class TranslatePrefsTest;

- FRIEND_TEST_ALL_PREFIXES(TranslatePrefsTest, CreateBlockedLanguages);

- FRIEND_TEST_ALL_PREFIXES(TranslatePrefsTest,

- CreateBlockedLanguagesNonEnglishUI);

// Merges two language sets to migrate to the language setting UI.

static void CreateBlockedLanguages(