Source/core/dom/Document.cpp - Issue 19782002: Make Blink stop scheduling its own Layout, and use the compositor's timer instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 19782002: Make Blink stop scheduling its own Layout, and use the compositor's timer instead (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: With test changes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/svg/as-image/animated-svg-as-image-same-image-expected.png ('k') | Source/core/page/FrameView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index b3fc7f14359dada020f4dfa5ed5727064c2bfc11..fa014066699bfd51c1b31e6084fadf777b97c76c 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -1718,7 +1718,7 @@ void Document::updateLayout()

StackStats::LayoutCheckPoint layoutCheckPoint;

// Only do a layout if changes have occurred that make it necessary.

- if (frameView && renderer() && (frameView->layoutPending() || renderer()->needsLayout()))

+ if (frameView && renderer() && (frameView->layoutIsScheduledWithEmbedder() || renderer()->needsLayout()))

frameView->layout();

// FIXME: Using a Task doesn't look a good idea.

@@ -2316,9 +2316,10 @@ bool Document::shouldScheduleLayout()

bool Document::shouldParserYieldAgressivelyBeforeScriptExecution()

{

- return view() && view()->layoutPending() && !minimumLayoutDelay();

+ return view() && view()->layoutIsScheduledWithEmbedder() && !minimumLayoutDelay();

}

+// FIXME: I believe this whole function is useless.

int Document::minimumLayoutDelay()

{

if (m_overMinimumLayoutThreshold)