runtime/vm/thread_interrupter.cc - Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_interrupter.cc

Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_interrupter.cc

diff --git a/runtime/vm/thread_interrupter.cc b/runtime/vm/thread_interrupter.cc

index 1e0d8cf044281cfe41289b6adc953123610470dd..fa14d2e0187d046b3acc28acd36593a6657ba5e5 100644

--- a/runtime/vm/thread_interrupter.cc

+++ b/runtime/vm/thread_interrupter.cc

@@ -157,7 +157,7 @@ void ThreadInterrupter::ThreadMain(uword parameters) {

MonitorLocker startup_ml(monitor_);

OSThread* os_thread = OSThread::Current();

ASSERT(os_thread != NULL);

- interrupter_thread_id_ = os_thread->join_id();

+ interrupter_thread_id_ = OSThread::GetCurrentThreadJoinId(os_thread);

thread_running_ = true;

startup_ml.Notify();

}

« no previous file with comments | « runtime/vm/os_thread_win.cc ('k') | runtime/vm/thread_pool.h » ('j') | no next file with comments »