runtime/bin/thread.h - Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/thread.h

Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/thread.h

diff --git a/runtime/bin/thread.h b/runtime/bin/thread.h

index d95675dd1fe2e46fc457cf1b41b47f3a7f6fafe1..979c77f05259114169e262d32413ad13ce289baf 100644

--- a/runtime/bin/thread.h

+++ b/runtime/bin/thread.h

@@ -51,7 +51,6 @@ class Thread {

static void SetThreadLocal(ThreadLocalKey key, uword value);

static intptr_t GetMaxStackSize();

static ThreadId GetCurrentThreadId();

- static bool Join(ThreadId id);

static intptr_t ThreadIdToIntPtr(ThreadId id);

static bool Compare(ThreadId a, ThreadId b);

static void GetThreadCpuUsage(ThreadId thread_id, int64_t* cpu_usage);

« no previous file with comments | « runtime/bin/eventhandler_win.cc ('k') | runtime/bin/thread_android.cc » ('j') | no next file with comments »