runtime/vm/thread_test.cc - Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_test.cc

Issue 1978153002: Uses an open thread handle as the ThreadJoinId on Windows. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_test.cc

diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc

index aa006dfb4acd8b0ef4835bc684b2859f900a446a..fc39c6703443cb8317768884f88e6826dbb5a536 100644

--- a/runtime/vm/thread_test.cc

+++ b/runtime/vm/thread_test.cc

@@ -440,7 +440,7 @@ VM_TEST_CASE(ThreadIterator_FindSelf) {

struct ThreadIteratorTestParams {

- ThreadId spawned_thread_join_id;

+ ThreadJoinId spawned_thread_join_id;

Monitor* monitor;

};

« runtime/vm/thread_pool.cc ('K') | « runtime/vm/thread_pool.cc ('k') | no next file » | no next file with comments »