Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 197813011: Fix result order reliance (Closed)

Created:
6 years, 9 months ago by iancottrell
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix result order reliance The old tests presumed result order in a way was safe because SkPicture was sorting the paint calls. This fixes the tests to not check result ordering, just presence BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M tests/TileGridTest.cpp View 3 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
lgtm
6 years, 9 months ago (2014-03-17 11:52:21 UTC) #1
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-17 11:52:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/197813011/1
6 years, 9 months ago (2014-03-17 11:52:51 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 12:08:01 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-17 12:08:02 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-17 12:14:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/197813011/1
6 years, 9 months ago (2014-03-17 12:14:41 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 12:14:51 UTC) #8
Message was sent while issue was closed.
Change committed as 13828

Powered by Google App Engine
This is Rietveld 408576698