Issue 19781008: Introduce toSVGRectElement(), use it

Issue 19781008: Introduce toSVGRectElement(), use it (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive

Modified:
7 years, 5 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce toSVGRectElement(), use it As a step to change static_cast with toSVGXXX, static_cast<SVGRectElement*> can be changed with toSVGRectElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154897

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
M	Source/core/rendering/svg/RenderSVGRect.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/SVGPathData.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGRenderTreeAsText.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGRectElement.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/19781008/diff/6001/Source/core/rendering/svg/RenderSVGRect.cpp File Source/core/rendering/svg/RenderSVGRect.cpp (left): https://codereview.chromium.org/19781008/diff/6001/Source/core/rendering/svg/RenderSVGRect.cpp#oldcode54 Source/core/rendering/svg/RenderSVGRect.cpp:54: ASSERT(rect); Why do you remove the ASSERT?

7 years, 5 months ago (2013-07-24 10:16:06 UTC) #2

gyuyoung-inactive

On 2013/07/24 10:16:06, tkent wrote: > https://codereview.chromium.org/19781008/diff/6001/Source/core/rendering/svg/RenderSVGRect.cpp > File Source/core/rendering/svg/RenderSVGRect.cpp (left): > > https://codereview.chromium.org/19781008/diff/6001/Source/core/rendering/svg/RenderSVGRect.cpp#oldcode54 > ...

7 years, 5 months ago (2013-07-25 03:31:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19781008/10001

7 years, 5 months ago (2013-07-25 03:34:25 UTC) #5

Message was sent while issue was closed.

Change committed as 154897

Expand Messages | Collapse Messages