Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978093002: Disable testPressNextFromEditTextAndType webview test (Closed)

Created:
4 years, 7 months ago by ssid
Modified:
4 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testPressNextFromEditTextAndType webview test The Android GN bot is broken. So disabling this test for now. BUG=611928 Committed: https://crrev.com/922b6a34547fd24f69a4adb5092b5c488c8aea38 Cr-Commit-Position: refs/heads/master@{#393724}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : add import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ssid
could you please see if this is fine. I do not have a lot of ...
4 years, 7 months ago (2016-05-14 00:42:54 UTC) #2
boliu
https://codereview.chromium.org/1978093002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java (right): https://codereview.chromium.org/1978093002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java#newcode102 android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java:102: @DisabledTest // crbug.com/611928 does this compile? don't you need ...
4 years, 7 months ago (2016-05-14 00:43:58 UTC) #3
ssid
Sorry, i removed an extra line before submitting. is it good now?
4 years, 7 months ago (2016-05-14 00:50:22 UTC) #4
boliu
lgtm
4 years, 7 months ago (2016-05-14 00:50:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978093002/40001
4 years, 7 months ago (2016-05-14 00:52:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-14 01:24:14 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/922b6a34547fd24f69a4adb5092b5c488c8aea38 Cr-Commit-Position: refs/heads/master@{#393724}
4 years, 7 months ago (2016-05-14 01:25:55 UTC) #10
jbudorick
4 years, 7 months ago (2016-05-24 12:48:15 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2000373004/ by jbudorick@chromium.org.

The reason for reverting is: Android GN is gone..

Powered by Google App Engine
This is Rietveld 408576698