Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1978083004: Don't link application support into shell client library (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, jshin+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't link application support into shell client library We have some application support code stuffed in services/shell/public/cpp which exports symbols to be fixed up at runtime by the runner for early process initialization. Any dependents will in turn export these symbols, often unnecessarily. This removes these sources from the public/cpp target and introduces a new application_support target for Mojo binaries to link against. BUG=611911 R=ben@chromium.org Committed: https://crrev.com/e98fa42ceeeb3b146186cf2676109190aece9881 Cr-Commit-Position: refs/heads/master@{#393765}

Patch Set 1 #

Patch Set 2 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -73 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/mojo_application.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 4 chunks +10 lines, -16 lines 0 comments Download
D services/shell/public/cpp/initialize_base_and_icu.cc View 1 chunk +0 lines, -52 lines 0 comments Download
A + services/shell/public/cpp/lib/initialize_base_and_icu.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M services/shell/shell_public.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-15 00:18:27 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 7 months ago (2016-05-15 00:20:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083004/1
4 years, 7 months ago (2016-05-15 00:23:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/200763)
4 years, 7 months ago (2016-05-15 00:32:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083004/20001
4 years, 7 months ago (2016-05-15 01:35:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/111360)
4 years, 7 months ago (2016-05-15 02:27:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083004/20001
4 years, 7 months ago (2016-05-15 02:51:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-15 03:22:20 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-15 03:23:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e98fa42ceeeb3b146186cf2676109190aece9881
Cr-Commit-Position: refs/heads/master@{#393765}

Powered by Google App Engine
This is Rietveld 408576698