Move cc ParamTraits to cc/ipc

Move cc ParamTraits to cc/ipc

This CL moves the ParamTraits but doesn't yet remove the associated unit/perf
tests. I'll do that in a subsequent patch.

The end result is all cc serialization code should live in cc/ipc.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/812b8489cadee4758ec6ffbe0930f96539374467
Cr-Commit-Position: refs/heads/master@{#393884}

[Fady Samuel, 2016-05-13 22:42:28]

Description was changed from

==========
Move cc ParamTraits to cc/ipc

This CL moves the ParamTraits but doesn't yet remove the associated unit/perf
tests. I'll do that in a subsequent patch.

The end result is all cc serialization code should live in cc/ipc.

BUG=611802
==========

to

==========
Move cc ParamTraits to cc/ipc

This CL moves the ParamTraits but doesn't yet remove the associated unit/perf
tests. I'll do that in a subsequent patch.

The end result is all cc serialization code should live in cc/ipc.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-05-13 23:52:01]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-05-13 23:52:23]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org, tsepez@chromium.org

[Fady Samuel, 2016-05-13 23:52:24]

+danakj@ for cc.
+tsepez@ for ipc.

[commit-bot: I haz the power, 2016-05-13 23:52:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/20001

[commit-bot: I haz the power, 2016-05-13 23:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 23:56:39]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Tom Sepez, 2016-05-13 23:57:39]

https://codereview.chromium.org/1978053002/diff/20001/cc/ipc/cc_param_traits.h
File cc/ipc/cc_param_traits.h (right):

https://codereview.chromium.org/1978053002/diff/20001/cc/ipc/cc_param_traits....
cc/ipc/cc_param_traits.h:19: #ifndef CC_IPC_CC_PARAM_TRAITS_H_
nit: curious as to why you moved the guard macros?

[Fady Samuel, 2016-05-14 00:06:47]

PTAL

https://codereview.chromium.org/1978053002/diff/20001/cc/ipc/cc_param_traits.h
File cc/ipc/cc_param_traits.h (right):

https://codereview.chromium.org/1978053002/diff/20001/cc/ipc/cc_param_traits....
cc/ipc/cc_param_traits.h:19: #ifndef CC_IPC_CC_PARAM_TRAITS_H_
On 2016/05/13 23:57:39, Tom Sepez wrote:
> nit: curious as to why you moved the guard macros?

No good reason. The existing code was like this. Fixed.

[Fady Samuel, 2016-05-14 00:06:57]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 00:07:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/40001

[Tom Sepez, 2016-05-14 00:10:17]

IPC LGTM once the bots are happy.  Thanks.

[commit-bot: I haz the power, 2016-05-14 00:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 00:12:45]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-05-14 00:25:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 00:26:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/60001

[commit-bot: I haz the power, 2016-05-14 00:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 00:31:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Fady Samuel, 2016-05-14 00:57:26]

Patchset #5 (id:80001) has been deleted

[Fady Samuel, 2016-05-14 01:05:17]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 01:05:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/100001

[commit-bot: I haz the power, 2016-05-14 01:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 01:09:36]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-05-14 01:19:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 01:20:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/120001

[commit-bot: I haz the power, 2016-05-14 01:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 01:23:51]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-05-14 01:32:34]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 01:32:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/140001

[commit-bot: I haz the power, 2016-05-14 01:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 01:36:26]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Fady Samuel, 2016-05-14 01:42:23]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 01:42:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/160001

[commit-bot: I haz the power, 2016-05-14 01:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 01:56:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-05-14 01:56:35]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 01:56:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/180001

[Fady Samuel, 2016-05-14 02:06:56]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-05-14 02:06:57]

+piman@ for content/

[commit-bot: I haz the power, 2016-05-14 02:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 02:08:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-05-14 04:03:44]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 04:03:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/200001

[Fady Samuel, 2016-05-14 05:09:11]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-14 05:09:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/220001

[commit-bot: I haz the power, 2016-05-14 06:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 06:25:33]

Dry run: This issue passed the CQ dry run.

[piman, 2016-05-16 17:51:51]

LGTM, but should cc_messages_{perf,unit}test.cc move to cc/ipc then? Maybe as a
follow-up?

[Fady Samuel, 2016-05-16 17:52:20]

On 2016/05/16 17:51:51, piman OOO back 2016-5-16 wrote:
> LGTM, but should cc_messages_{perf,unit}test.cc move to cc/ipc then? Maybe as
a
> follow-up?

Yup, I'll do it as a followup.

[Fady Samuel, 2016-05-16 17:52:28]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-05-16 17:52:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1978053002/#ps220001
(title: "Ignore size_t warnings")

[commit-bot: I haz the power, 2016-05-16 17:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978053002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978053002/220001

[commit-bot: I haz the power, 2016-05-16 18:52:33]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-05-16 18:53:58]

Description was changed from

==========
Move cc ParamTraits to cc/ipc

This CL moves the ParamTraits but doesn't yet remove the associated unit/perf
tests. I'll do that in a subsequent patch.

The end result is all cc serialization code should live in cc/ipc.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Move cc ParamTraits to cc/ipc

This CL moves the ParamTraits but doesn't yet remove the associated unit/perf
tests. I'll do that in a subsequent patch.

The end result is all cc serialization code should live in cc/ipc.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/812b8489cadee4758ec6ffbe0930f96539374467
Cr-Commit-Position: refs/heads/master@{#393884}
==========

[commit-bot: I haz the power, 2016-05-16 18:54:00]

Patchset 11 (id:??) landed as
https://crrev.com/812b8489cadee4758ec6ffbe0930f96539374467
Cr-Commit-Position: refs/heads/master@{#393884}

[Evan Stade, 2016-05-16 19:56:47]

On 2016/05/16 18:54:00, commit-bot: I haz the power wrote:
> Patchset 11 (id:??) landed as
> https://crrev.com/812b8489cadee4758ec6ffbe0930f96539374467
> Cr-Commit-Position: refs/heads/master@{#393884}

seems like the cast warning suppression didn't take on this bot:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/717/steps/com...

[Fady Samuel, 2016-05-16 20:06:54]

On 2016/05/16 19:56:47, Evan Stade wrote:
> On 2016/05/16 18:54:00, commit-bot: I haz the power wrote:
> > Patchset 11 (id:??) landed as
> > https://crrev.com/812b8489cadee4758ec6ffbe0930f96539374467
> > Cr-Commit-Position: refs/heads/master@{#393884}
> 
> seems like the cast warning suppression didn't take on this bot:
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/717/steps/com...

Fix is coming: https://codereview.chromium.org/1982783002/

[danakj, 2016-05-16 20:12:08]

Do we not need a security review of those files anymore? There's no OWNERS
specified for cc/ipc/ here.

[Fady Samuel, 2016-05-16 20:12:59]

On 2016/05/16 20:12:08, danakj wrote:
> Do we not need a security review of those files anymore? There's no OWNERS
> specified for cc/ipc/ here.

My bad, will add.