Check that constant is an integer before getting its value in HGraphBuilder::MatchRotateRight.

src/hydrogen.cc

Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index ce5ad80b11ca44f026650735d637e66effce8d34..5787ba4d588589cd78a9f65e516ec8827bbe68bb 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -8933,12 +8933,7 @@ static bool ShiftAmountsAllowReplaceByRotate(HValue* sa,
   if (!const32_minus_sa->IsSub()) return false;
   HSub* sub = HSub::cast(const32_minus_sa);
   if (sa != sub->right()) return false;

[Sven Panne, 2014/03/13 11:23:17]

I think this line can be removed, it is redundant. Slowly things get readable
here. :-)

[ulan, 2014/03/13 11:50:15]

Done.

-  HValue* const32 = sub->left();
-  if (!const32->IsConstant() ||
-      HConstant::cast(const32)->Integer32Value() != 32) {
-    return false;
-  }
-  return (sub->right() == sa);
+  return sub->left()->EqualsInteger32Constant(32)) && sub->right() == sa;
 }