Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/code_view.html

Issue 197803004: Add dead CodeRegionTable for tracking overwritten Dart code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/elements.html ('k') | runtime/bin/vmservice/client/lib/src/elements/disassembly_entry.dart » ('j') | runtime/bin/vmservice/client/lib/src/service/cache.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/elements/code_view.html
diff --git a/runtime/bin/vmservice/client/lib/src/elements/code_view.html b/runtime/bin/vmservice/client/lib/src/elements/code_view.html
index 7df27a397c067cc4c22bcc800e5dccb21405e3dd..39d182f24b06124eb6147eee0c78ae88addff14b 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/code_view.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/code_view.html
@@ -1,9 +1,6 @@
-<head>
- <link rel="import" href="disassembly_entry.html">
- <link rel="import" href="function_ref.html">
- <link rel="import" href="observatory_element.html">
- <link rel="import" href="nav_bar.html">
-</head>
+<link rel="import" href="function_ref.html">
+<link rel="import" href="observatory_element.html">
+<link rel="import" href="nav_bar.html">
<polymer-element name="code-view" extends="observatory-element">
<template>
<nav-bar>
@@ -12,29 +9,75 @@
<nav-menu link="." anchor="{{ code.name }}" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
</nav-bar>
-
- <div class="row">
- <div class="col-md-8 col-md-offset-2">
- <div class="{{ cssPanelClass }}">
- <div class="panel-heading">
- <span>Disassembled code for function: </span>
- <function-ref ref="{{ code.function }}"></function-ref>
+ <style>
+ .content {
+ padding-left: 10%;
+ font: 400 14px 'Montserrat', sans-serif;
+ }
+ h1 {
+ font: 400 18px 'Montserrat', sans-serif;
+ }
+ .member {
+ vertical-align: top;
+ padding: 3px 0 3px 1em;
+ font: 400 14px 'Montserrat', sans-serif;
+ }
+ .memberBold {
+ vertical-align: top;
+ padding: 3px 0 3px 1em;
+ font: 400 14px 'Montserrat', sans-serif;
+ }
turnidge 2014/03/13 18:09:09 To keep in sync with my changes I'm making now...
Cutch 2014/03/13 20:52:26 Done.
+ .monospace {
+ font-family: consolas, courier, monospace;
+ font-size: 1em;
+ line-height: 1.2em;
+ white-space: nowrap;
+ }
+ </style>
+ <div class="content">
+ <h1>Code for {{ code.name }}</h1>
+ <table>
+ <tr>
+ <td class="memberBold">kind</td>
+ <td class="member">{{code.kind}}</td>
+ </tr>
+ <tr>
+ <td class="memberBold">function</td>
+ <td class="member">
+ <function-ref ref="{{code.function}}">
+ </function-ref>
+ </td>
+ </tr>
+ <tr>
+ <td class="memberBold">Inclusive</td>
+ <td class="member">{{ code.formattedInclusiveTicks }}</td>
+ </tr>
+ <tr>
+ <td class="memberBold">Exclusive</td>
+ <td class="member">{{ code.formattedExclusiveTicks }}</td>
+ </tr>
+ </table>
+ </div>
+ <hr>
+ <div class="content">
+ <template if="{{ code.hasDisassembly }}">
+ <div class="row">
+ <div class="col-md-2 memberBold">Inclusive</div>
+ <div class="col-md-2 memberBold">Exclusive</div>
+ <div class="col-md-2 memberBold">Address</div>
+ <div class="col-md-6 memberBold">Disassembly</div>
</div>
- <div class="panel-body">
- <div class="row">
- <div class="col-md-2"><strong>Inclusive</strong></div>
- <div class="col-md-2"><strong>Exclusive</strong></div>
- <div class="col-md-2"><strong>Address</strong></div>
- <div class="col-md-6"><strong>Disassembly</strong></div>
- </div>
- <template repeat="{{ instruction in code.instructions }}">
- <disassembly-entry code="{{ code }}" instruction="{{ instruction }}">
- </disassembly-entry>
- </template>
+ </template>
+ <template repeat="{{ instruction in code.instructions }}">
+ <div class="row">
+ <div class="col-md-2 monospace">{{ instruction.formattedInclusive(code) }}</div>
+ <div class="col-md-2 monospace">{{ instruction.formattedExclusive(code) }}</div>
+ <div class="col-md-2 monospace">{{ instruction.formattedAddress() }}</div>
+ <div class="col-md-6 monospace">{{ instruction.human }}</div>
</div>
- </div>
+ </template>
</div>
- </div>
+ </template>
</template>
<script type="application/dart" src="code_view.dart"></script>
</polymer-element>
« no previous file with comments | « runtime/bin/vmservice/client/lib/elements.html ('k') | runtime/bin/vmservice/client/lib/src/elements/disassembly_entry.dart » ('j') | runtime/bin/vmservice/client/lib/src/service/cache.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698