Revert "Fix TypedArray Property optimizations", add regression test and eliminate dead code

test/mjsunit/regress/regress-610633.js

+
 // Copyright 2013 the V8 project authors. All rights reserved.

[adamk, 2016/05/13 20:33:39]

We now use a shorter copyright boilerplate (which you can find in newer files):

// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

[gsathya, 2016/05/13 21:11:52]

Done.

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --no-use-osr
-
-function foo(a, i, v) {
-  a[0] = v;
-  a[i] = v;
+function getLength(a) {
+  return a.length;
 }
 
-function foo_int(a, i, v) {
-  a[0] = v;
-  a[i] = v;
+function getByteLength(a) {
+  return a.byteLength;
 }
 
-var A1 = [1.2, 2.3];
-var A2 = [1.2, 2.3];
-var A3 = [1.2, 2.3];
+function getByteOffset(a) {
+  return a.byteOffset;
+}
 
-var A1_int = [12, 23];
-var A2_int = [12, 23];
-var A3_int = [12, 23];
+var a = new Uint8Array([1, 2, 3]);
+getLength(a);
+getLength(a);
 
-foo(A1, 1, 3.4);
-foo(A2, 1, 3.4);
-%OptimizeFunctionOnNextCall(foo);
-foo(A3, 1, 3.4);
+Object.defineProperty(a.__proto__, 'length',  {

[adamk, 2016/05/13 20:33:39]

Formatting is weird here, looks like you have an extra space between ',' and
'{'. Also I think this all fits on one line. Same applies to cut-and-pasted code
below.

[gsathya, 2016/05/13 21:11:53]

Done.

+  value: 42
+});
 
-foo_int(A1_int, 1, 34);
-foo_int(A2_int, 1, 34);
-%OptimizeFunctionOnNextCall(foo_int);
-foo_int(A3_int, 1, 34);
+assertEquals(getLength(a), 42);

[adamk, 2016/05/13 20:33:39]

Nit: the ordering for assertEquals is "expected, actual". Same here and below.

[gsathya, 2016/05/13 21:11:52]

Done.

+assertEquals(a.length, 42);
 
-assertEquals(A1[0], A3[0]);
-assertEquals(A1[1], A3[1]);
-assertEquals(A1_int[0], A3_int[0]);
-assertEquals(A1_int[1], A3_int[1]);
+getByteLength(a);
+getByteLength(a);
+
+Object.defineProperty(a.__proto__, 'byteLength',  {
+  value: 42
+});
+
+assertEquals(getByteLength(a), 42);
+assertEquals(a.byteLength, 42);
+
+getByteOffset(a);
+getByteOffset(a);
+
+Object.defineProperty(a.__proto__, 'byteOffset',  {
+  value: 42
+});
+
+assertEquals(getByteOffset(a), 42);
+assertEquals(a.byteOffset, 42);