Revert "Fix TypedArray Property optimizations", add regression test and eliminate dead code

Revert "Fix TypedArray Property optimizations", add regression test and eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
Committed: https://crrev.com/d33aedb7b9bfa7e2c05f5eb028565833a6f3f3ba
Cr-Commit-Position: refs/heads/master@{#36254}

[gsathya, 2016-05-13 20:25:50]

Description was changed from

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eleminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

to

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

[gsathya, 2016-05-13 20:26:24]

Description was changed from

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

to

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

[gsathya, 2016-05-13 20:26:38]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-05-13 20:26:55]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 20:27:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977983002/1

[adamk, 2016-05-13 20:33:39]

cc verwaest fyi

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
File test/mjsunit/regress/regress-610633.js (right):

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:2: // Copyright 2013 the V8 project
authors. All rights reserved.
We now use a shorter copyright boilerplate (which you can find in newer files):

// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:45: Object.defineProperty(a.__proto__,
'length',  {
Formatting is weird here, looks like you have an extra space between ',' and
'{'. Also I think this all fits on one line. Same applies to cut-and-pasted code
below.

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:49: assertEquals(getLength(a), 42);
Nit: the ordering for assertEquals is "expected, actual". Same here and below.

[commit-bot: I haz the power, 2016-05-13 20:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 20:58:22]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-05-13 21:11:53]

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
File test/mjsunit/regress/regress-610633.js (right):

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:2: // Copyright 2013 the V8 project
authors. All rights reserved.
On 2016/05/13 20:33:39, adamk wrote:
> We now use a shorter copyright boilerplate (which you can find in newer
files):
> 
> // Copyright 2016 the V8 project authors. All rights reserved.
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.

Done.

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:45: Object.defineProperty(a.__proto__,
'length',  {
On 2016/05/13 20:33:39, adamk wrote:
> Formatting is weird here, looks like you have an extra space between ',' and
> '{'. Also I think this all fits on one line. Same applies to cut-and-pasted
code
> below.

Done.

https://codereview.chromium.org/1977983002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-610633.js:49: assertEquals(getLength(a), 42);
On 2016/05/13 20:33:39, adamk wrote:
> Nit: the ordering for assertEquals is "expected, actual". Same here and below.

Done.

[adamk, 2016-05-13 21:54:11]

lgtm

[adamk, 2016-05-13 21:54:19]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:54:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977983002/20001

[commit-bot: I haz the power, 2016-05-13 22:30:48]

Description was changed from

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

to

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

[commit-bot: I haz the power, 2016-05-13 22:30:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 22:31:16]

Description was changed from

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634
==========

to

==========
Revert "Fix TypedArray Property optimizations", add regression test and
eliminate dead code

This reverts commit 41d571dfe87d70bb04a59e6e6dbe732b6df56277.

Reason for revert: This patch breaks the correctness of the typedarray
properties such as length, byteOffset, byteLength.

The accessor check optimization code is dead code eliminated. A follow
up patch will fix this optimization correctly.

BUG=chromium:593634

Committed: https://crrev.com/d33aedb7b9bfa7e2c05f5eb028565833a6f3f3ba
Cr-Commit-Position: refs/heads/master@{#36254}
==========

[commit-bot: I haz the power, 2016-05-13 22:31:17]

Patchset 2 (id:??) landed as
https://crrev.com/d33aedb7b9bfa7e2c05f5eb028565833a6f3f3ba
Cr-Commit-Position: refs/heads/master@{#36254}