Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 197793005: Convert scoped_ptr_malloc -> scoped_ptr, part 5. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Convert scoped_ptr_malloc -> scoped_ptr, part 5. scoped_ptr_malloc is deprecated; let's get rid of it. This takes care of the remaining conversions in media/. scoped_ptr requires a declaration of the deleter, unlike scoped_ptr_malloc, so declarations (minus the definitions) are in (the new) media/ffmpeg/ffmpeg_deleters.h. (The inline definitions remain in ffmpeg_common.h.) BUG=344245 R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257532

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -64 lines) Patch
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_audio_decoder.h View 3 chunks +3 lines, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.h View 2 chunks +3 lines, -5 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.h View 2 chunks +26 lines, -42 lines 0 comments Download
A media/ffmpeg/ffmpeg_deleters.h View 1 chunk +42 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_glue.h View 2 chunks +2 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 3 chunks +3 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-14 01:16:28 UTC) #1
viettrungluu
Friendly ping now that you're back (and presumably buried in email). (No rush.)
6 years, 9 months ago (2014-03-17 21:16:00 UTC) #2
DaleCurtis
lgtm
6 years, 9 months ago (2014-03-17 21:24:15 UTC) #3
viettrungluu
6 years, 9 months ago (2014-03-17 23:37:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r257532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698