Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc

Issue 1977923002: Implement pin storage backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
diff --git a/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc b/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7b719335add4499251f15e986e89e9badac104c8
--- /dev/null
+++ b/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
@@ -0,0 +1,161 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/login/quick_unlock/pin_storage.h"
+#include "chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h"
+
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/prefs/pref_service.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class PinStorageUnitTest : public testing::Test {
+ protected:
+ PinStorageUnitTest() : profile_(new TestingProfile()) {}
+
+ std::unique_ptr<TestingProfile> profile_;
+
+ DISALLOW_COPY_AND_ASSIGN(PinStorageUnitTest);
+};
+
+} // namespace
+
+// Provides test-only PinStorage APIs.
+class PinStorageTestApi {
+ public:
+ // Does *not* take ownership over |pin_storage|.
+ explicit PinStorageTestApi(chromeos::PinStorage* pin_storage)
+ : pin_storage_(pin_storage) {}
+
+ // Reduces the amount of strong auth time available by |time_delta|.
+ void ReduceRemainingStrongAuthTimeBy(const base::TimeDelta& time_delta) {
+ pin_storage_->last_strong_auth_ -= time_delta;
+ }
+
+ std::string PinSalt() const { return pin_storage_->PinSalt(); }
+
+ std::string PinSecret() const { return pin_storage_->PinSecret(); }
+
+ private:
+ chromeos::PinStorage* pin_storage_;
+
+ DISALLOW_COPY_AND_ASSIGN(PinStorageTestApi);
+};
+
+// Verifies that:
+// 1. Prefs are initially empty
+// 2. Setting a PIN will update the pref system.
+// 3. Removing a PIN clears prefs.
+TEST_F(PinStorageUnitTest, PinStorageWritesToPrefs) {
+ PrefService* prefs = profile_->GetPrefs();
+
+ EXPECT_EQ("", prefs->GetString(prefs::kQuickUnlockPinSalt));
+ EXPECT_EQ("", prefs->GetString(prefs::kQuickUnlockPinSecret));
+
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+ PinStorageTestApi pin_storage_test(pin_storage);
+
+ pin_storage->SetPin("1111");
+ EXPECT_TRUE(pin_storage->IsPinSet());
+ EXPECT_EQ(pin_storage_test.PinSalt(),
+ prefs->GetString(prefs::kQuickUnlockPinSalt));
+ EXPECT_EQ(pin_storage_test.PinSecret(),
+ prefs->GetString(prefs::kQuickUnlockPinSecret));
+ EXPECT_NE("", pin_storage_test.PinSalt());
+ EXPECT_NE("", pin_storage_test.PinSecret());
+
+ pin_storage->RemovePin();
+ EXPECT_FALSE(pin_storage->IsPinSet());
+ EXPECT_EQ("", prefs->GetString(prefs::kQuickUnlockPinSalt));
+ EXPECT_EQ("", prefs->GetString(prefs::kQuickUnlockPinSecret));
+}
+
+// Verifies that:
+// 1. Initial unlock attempt count is zero.
+// 2. Attempting unlock attempts correctly increases unlock attempt count.
+// 3. Resetting unlock attempt count correctly sets attempt count to 0.
+TEST_F(PinStorageUnitTest, UnlockAttemptCount) {
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+
+ EXPECT_EQ(0, pin_storage->unlock_attempt_count());
+
+ pin_storage->AddUnlockAttempt();
+ pin_storage->AddUnlockAttempt();
+ pin_storage->AddUnlockAttempt();
+ EXPECT_EQ(3, pin_storage->unlock_attempt_count());
+
+ pin_storage->ResetUnlockAttemptCount();
+ EXPECT_EQ(0, pin_storage->unlock_attempt_count());
+}
+
+// Verifies that marking the strong auth makes TimeSinceLastStrongAuth a > zero
+// value.
+TEST_F(PinStorageUnitTest, TimeSinceLastStrongAuthReturnsPositiveValue) {
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+ PinStorageTestApi pin_storage_test(pin_storage);
+
+ EXPECT_FALSE(pin_storage->HasStrongAuth());
+
+ pin_storage->MarkStrongAuth();
+
+ EXPECT_TRUE(pin_storage->HasStrongAuth());
+ pin_storage_test.ReduceRemainingStrongAuthTimeBy(
+ base::TimeDelta::FromSeconds(60));
+
+ EXPECT_TRUE(pin_storage->TimeSinceLastStrongAuth() >=
+ base::TimeDelta::FromSeconds(30));
+}
+
+// Verifies that the correct pin can be used to authenticate.
+TEST_F(PinStorageUnitTest, AuthenticationSucceedsWithRightPin) {
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+
+ pin_storage->SetPin("1111");
+
+ pin_storage->MarkStrongAuth();
+ EXPECT_TRUE(pin_storage->TryAuthenticatePin("1111"));
+}
+
+// Verifies that the correct pin will fail to authenticate if too many
+// authentication attempts have been made.
+TEST_F(PinStorageUnitTest, AuthenticationFailsFromTooManyAttempts) {
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+
+ pin_storage->SetPin("1111");
+
+ // Use up all of the authentication attempts so authentication fails.
+ pin_storage->MarkStrongAuth();
+ EXPECT_TRUE(pin_storage->IsPinAuthenticationAvailable());
+ for (int i = 0; i < chromeos::PinStorage::kMaximumUnlockAttempts; ++i)
+ EXPECT_FALSE(pin_storage->TryAuthenticatePin("foobar"));
+
+ // We used up all of the attempts, so entering the right PIN will still fail.
+ EXPECT_FALSE(pin_storage->IsPinAuthenticationAvailable());
+ EXPECT_FALSE(pin_storage->TryAuthenticatePin("1111"));
+}
+
+// Verifies that the correct pin will fail to authenticate if it has been too
+// long since a strong-auth/password authentication.
+TEST_F(PinStorageUnitTest, AuthenticationFailsFromTimeout) {
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile_.get());
+ PinStorageTestApi pin_storage_test(pin_storage);
+
+ pin_storage->SetPin("1111");
+ pin_storage->MarkStrongAuth();
+ EXPECT_TRUE(pin_storage->IsPinAuthenticationAvailable());
+
+ // Remove all of the strong auth time so that we have a strong auth timeout.
+ pin_storage_test.ReduceRemainingStrongAuthTimeBy(
+ chromeos::PinStorage::kStrongAuthTimeout + base::TimeDelta::FromHours(1));
+
+ EXPECT_FALSE(pin_storage->IsPinAuthenticationAvailable());
+}
« no previous file with comments | « chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698