Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977903002: Add support to the task model for the @required annotation (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support to the task model for the @required annotation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/23b02bc35112ebb955e006b87b3fbe03c5e071d7

Patch Set 1 #

Patch Set 2 : Remove unused code #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -54 lines) Patch
M pkg/analyzer/doc/tasks.html View 4 chunks +8 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/error/pending_error.dart View 1 chunk +81 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 8 chunks +85 lines, -48 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 10 chunks +105 lines, -6 lines 2 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-13 17:30:48 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1977903002/diff/20001/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1977903002/diff/20001/pkg/analyzer/lib/src/task/dart.dart#newcode2273 pkg/analyzer/lib/src/task/dart.dart:2273: * The name of the [RESOLVED_UNIT] input. All ...
4 years, 7 months ago (2016-05-13 17:59:49 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1977903002/diff/20001/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1977903002/diff/20001/pkg/analyzer/lib/src/task/dart.dart#newcode2273 pkg/analyzer/lib/src/task/dart.dart:2273: * The name of the [RESOLVED_UNIT] input. Grr. IntelliJ ...
4 years, 7 months ago (2016-05-13 18:11:14 UTC) #4
Brian Wilkerson
Committed patchset #2 (id:20001) manually as 23b02bc35112ebb955e006b87b3fbe03c5e071d7 (presubmit successful).
4 years, 7 months ago (2016-05-13 18:11:51 UTC) #6
pquitslund
4 years, 7 months ago (2016-05-13 20:59:12 UTC) #7
Message was sent while issue was closed. 
On 2016/05/13 18:11:51, Brian Wilkerson wrote:
> Committed patchset #2 (id:20001) manually as
> 23b02bc35112ebb955e006b87b3fbe03c5e071d7 (presubmit successful).

Late to the party but wow, this is fantastic!

Powered by Google App Engine
This is Rietveld 408576698