implement @JS classes

implement @JS classes

BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/d29e7ce5ad55100ab09bb81a79e96d9704dc6c46

[Harry Terkelsen, 2016-05-13 16:39:48]

het@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[Harry Terkelsen, 2016-05-13 16:39:49]

The first part of implementing @JS functionality.

As an example, suppose you have

@JS()
class Foo {
  Foo(a, b) { ... }
}

main() {
  var x = new Foo(1, 2);
}

it will be compiled as:

main() {
  var x = new self.Foo(1, 2);
}

Foo will not be included in the module since it only really exists in external
JS.

For @anonymous classes, we take the argument list, assert that it is empty, or a
single collection of named arguments, and just emit the object literal.

[Jacob, 2016-05-13 16:53:14]

On 2016/05/13 16:39:49, Harry Terkelsen wrote:
> The first part of implementing @JS functionality.
> 
> As an example, suppose you have
> 
> @JS()
> class Foo {
>   Foo(a, b) { ... }
> }
> 
> main() {
>   var x = new Foo(1, 2);
> }
> 
> it will be compiled as:
> 
> main() {
>   var x = new self.Foo(1, 2);
> }
> 
> Foo will not be included in the module since it only really exists in external
> JS.
> 
> For @anonymous classes, we take the argument list, assert that it is empty, or
a
> single collection of named arguments, and just emit the object literal.

Looks like you are also handling 
@anonymous classes.
Would be nice to enable some of the JS interop tests to better track what is
implemented and what isn't.

[Harry Terkelsen, 2016-05-13 17:09:52]

On 2016/05/13 16:53:14, Jacob wrote:
> On 2016/05/13 16:39:49, Harry Terkelsen wrote:
> > The first part of implementing @JS functionality.
> > 
> > As an example, suppose you have
> > 
> > @JS()
> > class Foo {
> >   Foo(a, b) { ... }
> > }
> > 
> > main() {
> >   var x = new Foo(1, 2);
> > }
> > 
> > it will be compiled as:
> > 
> > main() {
> >   var x = new self.Foo(1, 2);
> > }
> > 
> > Foo will not be included in the module since it only really exists in
external
> > JS.
> > 
> > For @anonymous classes, we take the argument list, assert that it is empty,
or
> a
> > single collection of named arguments, and just emit the object literal.
> 
> Looks like you are also handling 
> @anonymous classes.
> Would be nice to enable some of the JS interop tests to better track what is
> implemented and what isn't.

All of the js_typed_interop_anonymous_* tests are passing. I've enabled them.

[Jacob, 2016-05-13 17:20:00]

lgtm

[Harry Terkelsen, 2016-05-13 17:24:57]

Description was changed from

==========
implement @JS classes

BUG=
==========

to

==========
implement @JS classes

BUG=
R=jacobr@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/d29e7ce5ad55100ab09bb81a79e9...
==========

[Harry Terkelsen, 2016-05-13 17:24:59]

Committed patchset #3 (id:40001) manually as
d29e7ce5ad55100ab09bb81a79e96d9704dc6c46 (presubmit successful).