Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1977873003: Allow users to see more elements of a list/map in Observatory. (Closed)

Created:
4 years, 7 months ago by turnidge
Modified:
4 years, 7 months ago
Reviewers:
Cutch, sra1
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow users to see more elements of a list/map in Observatory. Closes #26004 BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4d473a819f44ebdd3ee45e4e81c6c9977097bc18

Patch Set 1 #

Patch Set 2 : Fix problems found during testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M runtime/observatory/lib/src/elements/instance_ref.dart View 1 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 3 chunks +11 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 6 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
4 years, 7 months ago (2016-05-13 21:50:30 UTC) #2
Cutch
lgtm
4 years, 7 months ago (2016-05-13 21:54:29 UTC) #3
turnidge
Committed patchset #2 (id:20001) manually as 4d473a819f44ebdd3ee45e4e81c6c9977097bc18 (presubmit successful).
4 years, 7 months ago (2016-05-13 22:07:09 UTC) #5
sra1
4 years, 7 months ago (2016-05-13 23:36:59 UTC) #7
Message was sent while issue was closed.
lgtm

Thanks!

Powered by Google App Engine
This is Rietveld 408576698