Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1977863003: SimpleCache: open with fewer seeks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@open-speeder-macbetter
Patch Set: self reviewed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9643bb8cef840917f12b86b392fa8fe3cb4a70c5..6cff1bdc7c986100ffed05bbe6e6c780779db193 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -50476,6 +50476,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SimpleCache.KeyMatchedOnOpen" enum="BooleanMatched">
<owner>gavinp@chromium.org</owner>
+ <obsolete>
Alexei Svitkine (slow) 2016/05/16 16:47:13 Nit: I think this goes before the owner?
gavinp 2016/05/16 17:16:25 On 2016/05/16 16:47:13, Alexei Svitkine wrote: > N
+ Deprecated 2016-05 as the match checking was moved back into the entry
+ itself, so this result is now reported in the SimpleCache.x.SyncOpenResult
+ histograms.
+ </obsolete>
<summary>
For each call to OpenEntry, whether the key on disk matched the request key.
</summary>
@@ -85774,7 +85779,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="Bad Magic Number"/>
<int value="4" label="Bad Version"/>
<int value="5" label="Can't Read Key"/>
- <int value="6" label="Key Mismatch (obsolete)"/>
+ <int value="6" label="Key Mismatch"/>
<int value="7" label="Hash Mismatch"/>
</enum>
« no previous file with comments | « net/disk_cache/simple/simple_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698