Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1977863003: SimpleCache: open with fewer seeks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@open-speeder-macbetter
Patch Set: actually fix test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 03604c2c3be284aad428fc627180c303fbec889f..54554d018aeda5b6f04c00d19b31359b50a8b31a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -50498,6 +50498,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="SimpleCache.KeyMatchedOnOpen" enum="BooleanMatched">
+ <obsolete>
+ Deprecated 2016-05 as the match checking was moved back into the entry
+ itself, so this result is now reported in the SimpleCache.x.SyncOpenResult
+ histograms.
+ </obsolete>
<owner>gavinp@chromium.org</owner>
<summary>
For each call to OpenEntry, whether the key on disk matched the request key.
@@ -50612,6 +50617,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SimpleCache.SyncKeySHA256Result"
+ enum="SimpleCacheSyncSHA256Result">
+ <owner>gavinp@chromium.org</owner>
+ <summary>
+ The result of the the key SHA256 check done when opening stream 0 for each
+ entry.
+ </summary>
+</histogram>
+
<histogram name="SimpleCache.SyncOpenEntryAge" units="hours">
<owner>gavinp@chromium.org</owner>
<summary>
@@ -85877,10 +85891,16 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="Bad Magic Number"/>
<int value="4" label="Bad Version"/>
<int value="5" label="Can't Read Key"/>
- <int value="6" label="Key Mismatch (obsolete)"/>
+ <int value="6" label="Key Mismatch"/>
<int value="7" label="Hash Mismatch"/>
</enum>
+<enum name="SimpleCacheSyncSHA256Result" type="int">
+ <int value="0" label="Not Present"/>
+ <int value="1" label="Matched"/>
+ <int value="2" label="Did Not Match"/>
+</enum>
+
<enum name="SimpleCacheSyncWriteResult" type="int">
<int value="0" label="Success"/>
<int value="1" label="Pretruncate Failure"/>
@@ -90054,6 +90074,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="SimpleCache.SyncCreateResult"/>
<affected-histogram name="SimpleCache.SyncCreateResult_WithIndex"/>
<affected-histogram name="SimpleCache.SyncCreateResult_WithoutIndex"/>
+ <affected-histogram name="SimpleCache.SyncKeySHA256Result"/>
<affected-histogram name="SimpleCache.SyncOpenEntryAge"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError"/>
<affected-histogram name="SimpleCache.SyncOpenPlatformFileError_WithIndex"/>
« no previous file with comments | « net/disk_cache/simple/simple_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698