components/offline_pages/offline_page_storage_manager.h - Issue 1977853004: [Offline pages] Adding ArchiveManager to abstract offline archives management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_storage_manager.h

Issue 1977853004: [Offline pages] Adding ArchiveManager to abstract offline archives management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding a missing destructor for OfflinePageStorageManager::Client Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_model.h ('k') | components/offline_pages/offline_page_storage_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_storage_manager.h

diff --git a/components/offline_pages/offline_page_storage_manager.h b/components/offline_pages/offline_page_storage_manager.h

index eebcff6c4538c66f0200b30d4008f80df6eceeb5..fd7f206ddfd639a15de483119e396a67ab7c791f 100644

--- a/components/offline_pages/offline_page_storage_manager.h

+++ b/components/offline_pages/offline_page_storage_manager.h

@@ -36,6 +36,8 @@ class OfflinePageStorageManager {

// This interface should be implemented by clients managed by storage manager.

class Client {

public:

+ virtual ~Client() {}

// Asks the client to get all offline pages and invoke |callback|.

virtual void GetAllPages(

const MultipleOfflinePageItemCallback& callback) = 0;

« no previous file with comments | « components/offline_pages/offline_page_model.h ('k') | components/offline_pages/offline_page_storage_manager_unittest.cc » ('j') | no next file with comments »