Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1977853003: Only read out selected node in processing menuListItemSelected event. (Closed)

Created:
4 years, 7 months ago by David Tseng
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only read out selected node in processing menuListItemSelected event. BUG=601365 TEST=chromevox_tests --gtest_filter=*.SelectOptionSelected CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/adeac25a3531f861d9ba30fdb8d80cea03f6511b Cr-Commit-Position: refs/heads/master@{#393648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 7 months ago (2016-05-13 17:26:30 UTC) #4
dmazzoni
lgtm
4 years, 7 months ago (2016-05-13 20:07:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977853003/1
4 years, 7 months ago (2016-05-13 20:47:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 21:44:00 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 21:46:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adeac25a3531f861d9ba30fdb8d80cea03f6511b
Cr-Commit-Position: refs/heads/master@{#393648}

Powered by Google App Engine
This is Rietveld 408576698