Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4202)

Unified Diff: base/win/scoped_handle_unittest.cc

Issue 1977833003: Add a buildflag to use the handle verifier in a per module mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a flag to use the HV in a single module mode. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/scoped_handle_test_dll.cc ('k') | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_handle_unittest.cc
diff --git a/base/win/scoped_handle_unittest.cc b/base/win/scoped_handle_unittest.cc
index 2d90f9fcf34f693552ffcc62ba31111520d3a393..5545548f089e6b7b86b2dfc694b7826fb2bac81f 100644
--- a/base/win/scoped_handle_unittest.cc
+++ b/base/win/scoped_handle_unittest.cc
@@ -11,6 +11,7 @@
#include "base/scoped_native_library.h"
#include "base/test/multiprocess_test.h"
#include "base/test/test_timeouts.h"
+#include "base/win/base_features.h"
#include "base/win/scoped_handle.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -48,6 +49,7 @@ TEST(ScopedHandleTest, ScopedHandle) {
EXPECT_EQ(magic_error, ::GetLastError());
}
+#if BUILDFLAG(SINGLE_MODULE_MODE_HANDLE_VERIFIER)
Will Harris 2016/06/01 16:46:40 why do these tests now depend on this, they didn't
Sébastien Marchand 2016/06/01 19:18:47 Hum, I thought that there was a #ifdef COMPONENT_B
TEST(ScopedHandleTest, ActiveVerifierTrackedHasBeenClosed) {
HANDLE handle = ::CreateMutex(nullptr, false, nullptr);
ASSERT_NE(HANDLE(nullptr), handle);
@@ -129,6 +131,7 @@ MULTIPROCESS_TEST_MAIN(ActiveVerifierChildProcess) {
return 0;
}
+#endif
} // namespace win
} // namespace base
« no previous file with comments | « base/win/scoped_handle_test_dll.cc ('k') | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698