Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1977833002: MIPS64: Fix allocation folding test failures. (Closed)

Created:
4 years, 7 months ago by Marija Antic
Modified:
4 years, 7 months ago
Reviewers:
ivica.bogosavljevic, balazs.kilvady, miran.karic, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix allocation folding test failures. Allocation folding tests are failing in debug mode, since the change https://codereview.chromium.org/1972553002 (6e15433db4df53bdb6d7e84fb7eba544ef6097f3) introduced a debug check in lithium-codegen-mips64.cc, line 5287. Reason for failure is to be found in https://codereview.chromium.org/1899813003 (61f5fbbb1926e1ffb672214a043e8c98db0e8af6), which is missing changes calling LFastAllocate in lithium-mips64.cc. BUG= Committed: https://crrev.com/ced0f49763ef18e874902e3f33b81d75f5a3b2ae Cr-Commit-Position: refs/heads/master@{#36246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Marija Antic
PTAL
4 years, 7 months ago (2016-05-13 12:03:48 UTC) #2
balazs.kilvady
On 2016/05/13 12:03:48, Marija Antic wrote: > PTAL lgtm In the message I would include ...
4 years, 7 months ago (2016-05-13 13:27:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977833002/1
4 years, 7 months ago (2016-05-13 13:47:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 14:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977833002/1
4 years, 7 months ago (2016-05-13 14:36:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 14:51:20 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 14:53:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ced0f49763ef18e874902e3f33b81d75f5a3b2ae
Cr-Commit-Position: refs/heads/master@{#36246}

Powered by Google App Engine
This is Rietveld 408576698