Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 197783005: Enable the Commands API. (Closed)

Created:
6 years, 9 months ago by Finnur
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Enable the Commands API. Enabling on all desktop platforms except ChromeOS, where it will remain behind a feature flag until feature complete (http://crbug.com/336761). Also removing the channel restriction. BUG=302437, 336761 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259312

Patch Set 1 #

Patch Set 2 : Documentation #

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M chrome/common/extensions/command.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/commands.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M extensions/common/feature_switch.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Finnur
6 years, 9 months ago (2014-03-25 12:48:48 UTC) #1
Finnur
Forgot to mention. Launching the API was requested by amjoyce and approved by saroop.
6 years, 9 months ago (2014-03-25 12:51:33 UTC) #2
Yoyo Zhou
LGTM
6 years, 9 months ago (2014-03-25 17:29:25 UTC) #3
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 9 months ago (2014-03-25 18:08:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/197783005/40001
6 years, 9 months ago (2014-03-25 18:08:32 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 20:02:18 UTC) #6
Message was sent while issue was closed.
Change committed as 259312

Powered by Google App Engine
This is Rietveld 408576698