Pressing spacebar on toolbar buttons triggers the ripple effect.

In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It will remain in that state unti the key is released

BUG=608996
Committed: https://crrev.com/bc4847d61fd0da6cd297f60311d9d7c58f391c75
Cr-Commit-Position: refs/heads/master@{#393907}

[kylix_rd, 2016-05-13 22:51:45]

Description was changed from

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=
==========

to

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=608996
==========

[kylix_rd, 2016-05-13 22:55:50]

kylixrd@chromium.org changed reviewers:
+ bruthig@chromium.org, sky@chromium.org

[kylix_rd, 2016-05-13 22:58:21]

This is another of the MD issues we're knocking out. Relatively simple change,
but did require an update to the InkDropDelegate to add a method to retrieve the
current InkDropState. This ensures the key-repeats don't continually call
OnAction() which will lead to an assertion.

https://codereview.chromium.org/1977793006/diff/1/ui/views/animation/test/tes...
File ui/views/animation/test/test_ink_drop_delegate.h (left):

https://codereview.chromium.org/1977793006/diff/1/ui/views/animation/test/tes...
ui/views/animation/test/test_ink_drop_delegate.h:20: 
Since InkDropDelegate can now return the current state, this method is now
redundant.

[bruthig, 2016-05-14 00:17:24]

One easy update request otherwise looks good.

https://codereview.chromium.org/1977793006/diff/1/ui/views/controls/button/cu...
File ui/views/controls/button/custom_button_unittest.cc (right):

https://codereview.chromium.org/1977793006/diff/1/ui/views/controls/button/cu...
ui/views/controls/button/custom_button_unittest.cc:118: InkDropState
GetTargetInkDropState() const override { return state_; }
Can you update TestInkDropDelegateThatTracksVisibilty to extend from
TestInkDropDelegate instead and make use of it's new
InkDropState::GetTargetInkDropState()?

[kylix_rd, 2016-05-16 14:10:07]

Updates based on feedback.

[bruthig, 2016-05-16 15:38:23]

lgtm

[sky, 2016-05-16 19:34:34]

LGTM

[kylix_rd, 2016-05-16 19:41:25]

The CQ bit was checked by kylixrd@chromium.org

[commit-bot: I haz the power, 2016-05-16 19:41:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977793006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977793006/40001

[commit-bot: I haz the power, 2016-05-16 19:50:54]

Description was changed from

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=608996
==========

to

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=608996
==========

[commit-bot: I haz the power, 2016-05-16 19:50:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-16 19:53:21]

Description was changed from

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=608996
==========

to

==========
In MD mode, pressing spacebar on toolbar buttons triggers the ripple effect. It
will remain in that state unti the key is released

BUG=608996

Committed: https://crrev.com/bc4847d61fd0da6cd297f60311d9d7c58f391c75
Cr-Commit-Position: refs/heads/master@{#393907}
==========

[commit-bot: I haz the power, 2016-05-16 19:53:21]

Patchset 3 (id:??) landed as
https://crrev.com/bc4847d61fd0da6cd297f60311d9d7c58f391c75
Cr-Commit-Position: refs/heads/master@{#393907}