Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1977793004:
Retract GrRenderTarget from AlphaClipMask code (Closed)
|
Created:
4 years, 7 months ago by robertphillips Modified:
4 years, 7 months ago Reviewers:
bsalomon CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRetract GrRenderTarget from AlphaClipMask code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977793004
Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
Committed: https://skia.googlesource.com/skia/+/c99b8f0351850cc1901fe359feb4ca357141346f
Patch Set 1 #Patch Set 2 : clean up #Patch Set 3 : update to ToT #Patch Set 4 : Fix memory leak #Messages
Total messages: 37 (20 generated)
Description was changed from ========== Retract renderTarget from AlphaClipMask code ========== to ========== Retract renderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Retract renderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/20001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1977793004/#ps40001 (title: "update to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/40001
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1975353002/ by bsalomon@google.com. The reason for reverting is: Possible cause of leak in ASAN bot: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-G....
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d ========== to ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/1977793004/#ps60001 (title: "Fix memory leak")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793004/60001
Message was sent while issue was closed.
Description was changed from ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d ========== to ========== Retract GrRenderTarget from AlphaClipMask code GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d Committed: https://skia.googlesource.com/skia/+/c99b8f0351850cc1901fe359feb4ca357141346f ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c99b8f0351850cc1901fe359feb4ca357141346f |
