third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp - Issue 1977783002: BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

Issue 1977783002: BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/heap/Heap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

index 12369461e2266b216437000964edf9f7f3801267..bd8841a6b42289fd1622c1456cd19f5f006a83d9 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

@@ -4,7 +4,7 @@

#include "platform/heap/BlinkGCMemoryDumpProvider.h"

-#include "platform/web_process_memory_dump_impl.h"

+#include "base/trace_event/process_memory_dump.h"

#include "public/platform/Platform.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "wtf/Threading.h"

@@ -13,11 +13,11 @@ namespace blink {

TEST(BlinkGCDumpProviderTest, MemoryDump)

{

- OwnPtr<WebProcessMemoryDump> dump = adoptPtr(new WebProcessMemoryDumpImpl());

- ASSERT(dump);

- BlinkGCMemoryDumpProvider::instance()->onMemoryDump(WebMemoryDumpLevelOfDetail::Detailed, dump.get());

- ASSERT(dump->getMemoryAllocatorDump(String::format("blink_gc")));

- ASSERT(dump->getMemoryAllocatorDump(String::format("blink_gc/allocated_objects")));

+ base::trace_event::MemoryDumpArgs args = { base::trace_event::MemoryDumpLevelOfDetail::DETAILED };

+ std::unique_ptr<base::trace_event::ProcessMemoryDump> dump(new base::trace_event::ProcessMemoryDump(nullptr));

+ BlinkGCMemoryDumpProvider::instance()->OnMemoryDump(args, dump.get());

+ DCHECK(dump->GetAllocatorDump("blink_gc"));

+ DCHECK(dump->GetAllocatorDump("blink_gc/allocated_objects"));

}

} // namespace blink