Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1977753003: Fix actions.xml missing about flags field for passive listeners. (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, Moe
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix actions.xml missing about flags field for passive listeners. In change https://codereview.chromium.org/1965493002/ actions.xml was not updated. Correctly update this xml file. BUG=599611 Committed: https://crrev.com/3d0d596af9ff7592a0b6fe390e54491349950175 Cr-Commit-Position: refs/heads/master@{#393635}

Patch Set 1 #

Patch Set 2 : Make a complete sentence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dtapuska
4 years, 7 months ago (2016-05-13 20:01:12 UTC) #3
jwd
lgtm
4 years, 7 months ago (2016-05-13 20:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977753003/20001
4 years, 7 months ago (2016-05-13 20:04:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 20:55:48 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 20:56:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d0d596af9ff7592a0b6fe390e54491349950175
Cr-Commit-Position: refs/heads/master@{#393635}

Powered by Google App Engine
This is Rietveld 408576698