Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197773004: Move avatar holder code to ash (Closed)

Created:
6 years, 9 months ago by oshima
Modified:
6 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tfarina, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move avatar holder img/code to ash Removed GetLoggedInUsers method that is no longer used. I'm planning to move frame related code to ash/frame (such as custom_frame_view_ash, caption). BUG=338782 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257141

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix win build 2 #

Patch Set 5 : fix unit test #

Patch Set 6 : clang fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -115 lines) Patch
M ash/ash.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A ash/frame/frame_util.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ash/frame/frame_util.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ash/session_state_delegate.h View 4 chunks +15 lines, -5 lines 0 comments Download
M ash/session_state_delegate_stub.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/session_state_delegate_stub.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M ash/test/test_session_state_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 2 chunks +9 lines, -2 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/avatar_holder.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/cros/avatar_holder_mask.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/cros/avatar_holder.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/cros/avatar_holder_mask.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/avatar_menu_chromeos.cc View 1 chunk +4 lines, -34 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.h View 1 2 3 4 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_stub.h View 1 2 3 4 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_stub.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 2 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 43 (0 generated)
oshima
https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (left): https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/views/frame/browser_view.cc#oldcode620 chrome/browser/ui/views/frame/browser_view.cc:620: #endif The rest of the code always returns false ...
6 years, 9 months ago (2014-03-12 21:32:36 UTC) #1
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc (right): https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc#newcode373 chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:373: // can return here. I think you can ...
6 years, 9 months ago (2014-03-13 00:08:15 UTC) #2
oshima
sky -> chrome/browser/ui/browser_navigator_browsertest_chromeos.cc chrome/browser/ui/views/frame/browser_view.cc https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc (right): https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc#newcode373 chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:373: // can return here. On ...
6 years, 9 months ago (2014-03-13 01:02:52 UTC) #3
oshima
On 2014/03/13 01:02:52, oshima wrote: > sky -> > chrome/browser/ui/browser_navigator_browsertest_chromeos.cc > chrome/browser/ui/views/frame/browser_view.cc > > https://codereview.chromium.org/197773004/diff/30001/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc ...
6 years, 9 months ago (2014-03-13 06:04:43 UTC) #4
oshima
On 2014/03/13 06:04:43, oshima wrote: > On 2014/03/13 01:02:52, oshima wrote: > > sky -> ...
6 years, 9 months ago (2014-03-13 07:15:21 UTC) #5
sky
Said files LGTM
6 years, 9 months ago (2014-03-13 15:59:48 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-13 22:30:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/130001
6 years, 9 months ago (2014-03-13 22:30:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 23:08:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-13 23:08:39 UTC) #10
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-13 23:53:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/150001
6 years, 9 months ago (2014-03-13 23:54:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/150001
6 years, 9 months ago (2014-03-14 00:27:26 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 00:56:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-14 00:56:35 UTC) #15
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 00:57:05 UTC) #16
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 00:58:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/190001
6 years, 9 months ago (2014-03-14 00:59:06 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 02:17:34 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=281761
6 years, 9 months ago (2014-03-14 02:17:34 UTC) #20
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 02:32:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/190001
6 years, 9 months ago (2014-03-14 02:33:32 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 02:41:26 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-14 02:41:27 UTC) #24
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 02:59:17 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/190001
6 years, 9 months ago (2014-03-14 02:59:30 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 03:53:29 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-14 03:53:30 UTC) #28
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 04:43:24 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/190001
6 years, 9 months ago (2014-03-14 04:45:04 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 06:07:51 UTC) #31
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=236488
6 years, 9 months ago (2014-03-14 06:07:53 UTC) #32
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 07:23:09 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/80032
6 years, 9 months ago (2014-03-14 07:23:20 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 07:51:41 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-14 07:51:42 UTC) #36
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 08:28:26 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/260001
6 years, 9 months ago (2014-03-14 08:28:28 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 09:42:19 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-14 09:42:21 UTC) #40
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 9 months ago (2014-03-14 15:48:23 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/197773004/260001
6 years, 9 months ago (2014-03-14 15:49:46 UTC) #42
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 17:15:34 UTC) #43
Message was sent while issue was closed. 
Change committed as 257141

Powered by Google App Engine
This is Rietveld 408576698