Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 1977703002: Lightening fix for UMA metric test failure locally. (Closed)

Created:
4 years, 7 months ago by ymalik
Modified:
4 years, 7 months ago
Reviewers:
skobes
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lightening fix for UMA metric test failure locally. This probably has something to do with the way the histogram is defined. I did some digging but didn't get to the bottom of it yet. Putting this up for now as a temporary solution to avoid annoyance caused by it. BUG=611552 Committed: https://crrev.com/24128234ced24bc09936c0695a362140c25b4ac4 Cr-Commit-Position: refs/heads/master@{#393464}

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 2 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ymalik
4 years, 7 months ago (2016-05-13 02:09:57 UTC) #3
skobes
lgtm
4 years, 7 months ago (2016-05-13 02:36:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977703002/20001
4 years, 7 months ago (2016-05-13 06:28:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 07:28:26 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 07:29:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24128234ced24bc09936c0695a362140c25b4ac4
Cr-Commit-Position: refs/heads/master@{#393464}

Powered by Google App Engine
This is Rietveld 408576698