Issue 19777003: yasm: add support for targeting iOS (at least simulator) by copying mac->ios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19777003: yasm: add support for targeting iOS (at least simulator) by copying mac->ios (Closed)

Created:
7 years, 5 months ago by Ami GONE FROM CHROMIUM

Modified:
7 years, 5 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

yasm: add support for targeting iOS (at least simulator) by copying mac->ios BUG=https://code.google.com/p/webrtc/issues/detail?id=2106 R=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212643

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -2 lines)			Patch
M	third_party/yasm/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	third_party/yasm/source/config/ios/Makefile	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/yasm/source/config/ios/config.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/yasm/source/config/ios/libyasm-stdint.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	third_party/yasm/yasm_compile.gypi	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Alpha Left Google

LGTM. It's funny that it's iOS and X86 but okay.

7 years, 5 months ago (2013-07-19 18:37:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/19777003/1

7 years, 5 months ago (2013-07-19 19:08:38 UTC) #4

Ami GONE FROM CHROMIUM

7 years, 5 months ago (2013-07-19 20:38:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r212643 (presubmit successful).