Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 19777002: Revert 211950 "Display DNS probe results." (Closed)

Created:
7 years, 5 months ago by kareng
Modified:
7 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert 211950 "Display DNS probe results." > Display DNS probe results. > > 1. Modify the browser-side NetErrorTabHelper to send extra messages when it > starts or declines to start a DNS probe. > > 2. Create a new error domain, "dnsprobe", with errors for "might run a DNS > probe", "currently running a DNS probe", and all of the possible probe > results. > > 3. Modify ChromeContentRendererClient to give the renderer-side NetErrorHelper > a chance to choose the error strings before we call LocalizedError directly. > > 4. Catch DNS errors and provide the strings for the "might run a DNS probe" > pseudo-error instead. > > 5. Add a function to neterror.html that lets us re-render the template with a > new set of strings. > > 6. When we get a "probe started" message, replace the strings with those for > the "currently running a DNS probe" pseudo-error. > > 7. When we get a "probe finished" message, replace the strings with those for > the probe result. > > 8. When we get a "probe not run" message, replace the strings with those for > the original error we received. > > BUG=156415 > TEST=DnsProbeBrowserTest > > Review URL: https://chromiumcodereview.appspot.com/13270005 TBR=ttuttle@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+670 lines, -1505 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -8 lines 0 comments Download
A + chrome/browser/net/dns_probe_job.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/net/dns_probe_job.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/net/dns_probe_job_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/net/dns_probe_runner.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/net/dns_probe_runner.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M chrome/browser/net/dns_probe_service.h View 1 chunk +42 lines, -34 lines 0 comments Download
M chrome/browser/net/dns_probe_service.cc View 4 chunks +237 lines, -153 lines 0 comments Download
M chrome/browser/net/dns_probe_service_unittest.cc View 2 chunks +163 lines, -76 lines 0 comments Download
D chrome/browser/net/dns_probe_test_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/net/dns_probe_test_util.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.h View 3 chunks +24 lines, -42 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 7 chunks +85 lines, -81 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/localized_error.cc View 4 chunks +0 lines, -59 lines 0 comments Download
M chrome/common/net/net_error_info.h View 1 chunk +5 lines, -60 lines 0 comments Download
D chrome/common/net/net_error_info.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A + chrome/common/net/net_error_tracker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/net/net_error_tracker.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/net/net_error_tracker_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/renderer/net/net_error_helper.h View 2 chunks +7 lines, -63 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 5 chunks +100 lines, -164 lines 0 comments Download
D chrome/renderer/net/net_error_helper_unittest.cc View 1 chunk +0 lines, -412 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 5 months ago (2013-07-18 14:20:06 UTC) #1
kareng
7 years, 5 months ago (2013-07-18 14:20:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r212349.

Powered by Google App Engine
This is Rietveld 408576698