Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6661)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 1977693003: Add metrics for permission prompt acceptance / denial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index c4c8001d215749510c9f390aad526442da0db199..438368e3cd4971ecedc83b2442019ebed246623d 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -65,6 +65,18 @@ class PermissionUmaUtil {
static void PermissionPromptShown(
const std::vector<PermissionBubbleRequest*>& requests);
+ // The following two functions can be combined with the PermissionPromptShown
+ // metrics to calculate accept, deny and ignore rates.
+ // Note that for coalesced permission bubbles, PermissionPromptAccepted will
+ // always be called, with |accept_states| containing whether each request was
+ // accepted or denied.
+ static void PermissionPromptAccepted(
+ const std::vector<PermissionBubbleRequest*>& requests,
+ const std::vector<bool>& accept_states);
+
+ static void PermissionPromptDenied(
+ const std::vector<PermissionBubbleRequest*>& requests);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
};

Powered by Google App Engine
This is Rietveld 408576698