Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977693002: Support CPU throttling on Windows (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support CPU throttling on Windows BUG=436111 Committed: https://crrev.com/f77e08f979f9ab5efcab7349fbf1fec1c6e51a49 Cr-Commit-Position: refs/heads/master@{#393670}

Patch Set 1 #

Total comments: 8

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M content/renderer/devtools/devtools_cpu_throttler.cc View 1 4 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
4 years, 7 months ago (2016-05-13 01:35:05 UTC) #2
caseq
https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc File content/renderer/devtools/devtools_cpu_throttler.cc (right): https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc#newcode129 content/renderer/devtools/devtools_cpu_throttler.cc:129: #elif OS_WIN defined(OS_WIN)? https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc#newcode139 content/renderer/devtools/devtools_cpu_throttler.cc:139: #elif OS_WIN ditto https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc#newcode156 ...
4 years, 7 months ago (2016-05-13 01:49:07 UTC) #3
alph
https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc File content/renderer/devtools/devtools_cpu_throttler.cc (right): https://codereview.chromium.org/1977693002/diff/1/content/renderer/devtools/devtools_cpu_throttler.cc#newcode129 content/renderer/devtools/devtools_cpu_throttler.cc:129: #elif OS_WIN On 2016/05/13 01:49:07, caseq wrote: > defined(OS_WIN)? ...
4 years, 7 months ago (2016-05-13 21:00:59 UTC) #4
caseq
lgtm
4 years, 7 months ago (2016-05-13 21:32:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977693002/20001
4 years, 7 months ago (2016-05-13 21:33:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 22:56:32 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:58:51 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f77e08f979f9ab5efcab7349fbf1fec1c6e51a49
Cr-Commit-Position: refs/heads/master@{#393670}

Powered by Google App Engine
This is Rietveld 408576698