Generate param traits size methods for IPC files in chrome/ (and traits it depends on).

Generate param traits size methods for IPC files in chrome/ (and traits it depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to get the chrome message generator to compile with the size traits.

This is a followup to r393058.

Committed: https://crrev.com/3db6b6d9b24c3c0d44df4929eb8b44605d338cbf
Cr-Commit-Position: refs/heads/master@{#393526}

[jam, 2016-05-12 23:23:12]

Description was changed from

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the content message generator to compile with the size traits.

This is a followup to r393058.
==========

to

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the content message generator to compile with the size traits.

This is a followup to r393058.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jam, 2016-05-12 23:28:23]

jam@chromium.org changed reviewers:
+ dcheng@chromium.org

[jam, 2016-05-13 01:33:43]

Description was changed from

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the content message generator to compile with the size traits.

This is a followup to r393058.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[dcheng, 2016-05-13 03:23:10]

LGTM with nits.

https://codereview.chromium.org/1977643002/diff/20001/chrome/common/cast_mess...
File chrome/common/cast_messages.cc (right):

https://codereview.chromium.org/1977643002/diff/20001/chrome/common/cast_mess...
chrome/common/cast_messages.cc:11: ParamTraits<uint64_t>::GetSize(s,
p.SerializeForIPC());
Nit: does GetParamSize() work here?

[Andrew Hayden (chromium.org), 2016-05-13 08:57:26]

andrewhayden@chromium.org changed reviewers:
+ andrewhayden@chromium.org

[Andrew Hayden (chromium.org), 2016-05-13 08:57:26]

components/translate/* LGTM

[jam, 2016-05-13 15:02:48]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-05-13 15:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977643002/20001

[jam, 2016-05-13 15:04:39]

Description was changed from

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
==========

[jam, 2016-05-13 15:04:47]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-05-13 15:05:34]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-05-13 15:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977643002/20001

[commit-bot: I haz the power, 2016-05-13 15:10:08]

Description was changed from

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
==========

to

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
==========

[commit-bot: I haz the power, 2016-05-13 15:10:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 15:11:04]

Description was changed from

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.
==========

to

==========
Generate param traits size methods for IPC files in chrome/ (and traits it
depends on).

This allows us to reuse these traits in Mojo if needed.

I didn't add GetSize to every single trait in chrome/ and below; just enough to
get the chrome message generator to compile with the size traits.

This is a followup to r393058.

Committed: https://crrev.com/3db6b6d9b24c3c0d44df4929eb8b44605d338cbf
Cr-Commit-Position: refs/heads/master@{#393526}
==========

[commit-bot: I haz the power, 2016-05-13 15:11:06]

Patchset 2 (id:??) landed as
https://crrev.com/3db6b6d9b24c3c0d44df4929eb8b44605d338cbf
Cr-Commit-Position: refs/heads/master@{#393526}