Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1977633002: Simplify Physical Web UrlManager logic (Closed)

Created:
4 years, 7 months ago by cco3
Modified:
4 years, 7 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Physical Web UrlManager logic UrlManager has several confusing methods that take parameters for the number of previously displayable URLs and the number of currently displayable URLs. This is no longer necessary given that we now store these values in member variables. This change simplifies these methods and their calling code. BUG=596668 Committed: https://crrev.com/a416f1b1baaf280fd829abd98e8016d2560c97a2 Cr-Commit-Position: refs/heads/master@{#393605}

Patch Set 1 #

Patch Set 2 : Add a test #

Patch Set 3 : Rebase #

Patch Set 4 : Add VisibleForTesting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -73 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 2 3 10 chunks +54 lines, -67 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 2 2 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
cco3
4 years, 7 months ago (2016-05-12 22:41:44 UTC) #2
mattreynolds
lgtm
4 years, 7 months ago (2016-05-12 23:09:06 UTC) #3
cco3
4 years, 7 months ago (2016-05-13 00:07:50 UTC) #5
nyquist
lgtm
4 years, 7 months ago (2016-05-13 17:47:35 UTC) #6
cco3
On 2016/05/13 17:47:35, nyquist wrote: > lgtm Thank you!
4 years, 7 months ago (2016-05-13 17:49:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633002/40001
4 years, 7 months ago (2016-05-13 17:50:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633002/60001
4 years, 7 months ago (2016-05-13 18:49:59 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-13 19:37:04 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 19:39:03 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a416f1b1baaf280fd829abd98e8016d2560c97a2
Cr-Commit-Position: refs/heads/master@{#393605}

Powered by Google App Engine
This is Rietveld 408576698