Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 197763016: Set the name of several iframes in browser resources (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Set the name of several iframes in browser resources Set the name of several iframes in browser resources in addition to their id, to avoid breakage when Blink gets updated so that an iframe's name is no longer set to its id when missing (as per specification). Several scripts / browser tests rely on the iframe's name being the same. R=arv, jochen BUG=347169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/inline_login.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 9 months ago (2014-03-14 19:18:37 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 9 months ago (2014-03-14 19:34:05 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-14 19:34:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197763016/1
6 years, 9 months ago (2014-03-14 19:35:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 20:05:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-14 20:05:31 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-14 20:10:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/197763016/1
6 years, 9 months ago (2014-03-14 20:11:24 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 22:00:06 UTC) #9
Message was sent while issue was closed.
Change committed as 257221

Powered by Google App Engine
This is Rietveld 408576698